From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: Resuming work on new semaphore
Date: Fri, 3 Apr 2015 00:39:10 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.11.1504030021400.8195@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20150402152642.GW6817@brightrain.aerifal.cx>
On Thu, 2 Apr 2015, Rich Felker wrote:
> > Interesting. To examine the issue under a different light, consider that from
> > the perspective of semaphore implementation, waiters that were killed,
> > stopped, or pre-empted forever in the middle of sem_wait are
> > indistinguishable.
>
> Yes, I noticed this too. In that sense, theoretically there should be
> no harm (aside from eventual overflow of pending wake counter) from
> having asynchronously-killed waiters, assuming the implementation is
> bug-free in the absence of async killing of waiters.
Did you mean "presence"? I'm having trouble understanding your phrase,
especially after "assuming ..."; can you elaborate or rephrase?
That waiters can die breaks an assumption that operations on val[0] and val[1]
do not under/overflow due to their range exceeding the number of
simultaneously live tasks.
> > Thus, subsequent sem_wait succeeds by effectively stealing
> > a post, and to make things consistent you can teach sem_trywait to steal posts
> > too (i.e. try atomic-decrement-if-positive val[1] just before returning
> > EAGAIN, return 0 if that succeeds).
>
> Hmm, perhaps that is valid. I'll have to think about it again. I was
> thinking of having sem_trywait unconditionally down the value (val[0])
> then immitate the exit path of sem_timedwait, but that's not valid
> because another waiter could race and prevent sem_trywait from ever
> being able to exit. But if it only does the down as a dec-if-positive
> then it seems like it can safely dec-if-positive the wake count before
> reporting failure.
I think my proposition above needs at least the following correction: when
trywait succeeds in stealing a post by dec-if-positive(val[1]), it should also
decrement val[0] before returning.
Are you sure your proposition is invalid? I don't think so. How is trywait
different from a timedwait with a timeout that immediately expires? That is
basically what your scheme should do.
Alexander
next prev parent reply other threads:[~2015-04-02 21:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 1:30 Rich Felker
2015-04-02 7:42 ` Alexander Monakov
2015-04-02 15:26 ` Rich Felker
2015-04-02 21:39 ` Alexander Monakov [this message]
2015-04-02 23:14 ` Rich Felker
2015-04-05 14:07 ` Alexander Monakov
2015-04-05 14:17 ` Alexander Monakov
2015-04-05 19:02 ` Rich Felker
2015-04-05 20:03 ` Alexander Monakov
2015-04-05 20:23 ` Rich Felker
2015-04-05 21:07 ` Alexander Monakov
2015-04-11 22:22 ` Alexander Monakov
2015-04-23 16:06 ` Rich Felker
2015-04-23 18:24 ` Alexander Monakov
2015-04-23 20:01 ` Alexander Monakov
2015-04-24 2:46 ` Rich Felker
2015-04-24 10:23 ` Alexander Monakov
2015-04-24 15:03 ` Rich Felker
2015-04-24 15:47 ` Alexander Monakov
2015-04-24 15:59 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.11.1504030021400.8195@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).