mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Explicit casts in ctype.h suppress compiler warnings
Date: Fri, 17 Apr 2015 13:59:14 +0300 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.11.1504171341080.11963@monopod.intra.ispras.ru> (raw)

For the following erroneous source code:

#include <ctype.h>
int f(char *c)
{
  return isdigit(c) || isspace(c);
}

GCC warns only for passing a pointer to isspace; isdigit is implemented as a
macro that casts its argument to unsigned, and the warning is suppresed
because the origin of the cast is in a system header.  Since isspace is
implemented with a static inline helper function, there is a warning.  With
glibc headers, no warning is issued in either case for a similar reason.

I think it would be nice if musl's ctype.h could aid the compiler in
diagnosing erroneous use, like it happens today for only for isspace() of all
macros declared there.  The cost of restructuring the header to achieve that
does not seem too high.  Thoughts?

Thanks.
Alexander


             reply	other threads:[~2015-04-17 10:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 10:59 Alexander Monakov [this message]
2015-04-17 16:49 ` Jens Gustedt
2015-04-17 16:52   ` Rich Felker
2015-04-17 18:24     ` Alexander Monakov
2015-04-17 18:35       ` Szabolcs Nagy
2015-04-17 19:43         ` Szabolcs Nagy
2015-04-17 20:21           ` Rich Felker
2015-04-17 20:32             ` Szabolcs Nagy
2015-04-17 20:34         ` Jens Gustedt
2015-04-17 21:36       ` Rich Felker
2015-04-18  2:03         ` Morten Welinder
2015-04-17 19:33     ` William Ahern
2015-04-17 16:50 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.11.1504171341080.11963@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).