mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: x86_64 and x32 fail to build
Date: Mon, 20 Apr 2015 22:21:31 +0300 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.11.1504202204010.2677@monopod.intra.ispras.ru> (raw)

After recent commits musl fails to build for x86_64 and x32.

When configuring on x86_64, configure mistakenly thinks the host compiler is
going to produce code for x32.  This is because __ILP32__ check wrongly
succeeds.  That is because it's looking for compilation failure due to #error
preprocessor directive, but compilation instead fails because vis.h is not
found (-include vis.h is added to CFLAGS with -I giving the path to it).  I
have used the following patch to proceed with the build:

diff --git a/configure b/configure
index 0e39694..cebee09 100755
--- a/configure
+++ b/configure
@@ -440,7 +440,7 @@ printf "%s\n" "$visibility"
 fi
 
 if test "x$visibility" == xyes ; then
-CFLAGS_AUTO="$CFLAGS_AUTO -include vis.h"
+CFLAGS_AUTO="$CFLAGS_AUTO  -I./arch/$ARCH -I src/internal -I./include -include vis.h"
 CFLAGS_AUTO="${CFLAGS_AUTO# }"
 fi
 

Would be nice to rework trycppif configure function to be robust against this
kind of failures.

When targeting x32, build fails due to "jmp" instruction expecting a 64-bit
argument.  At least the following change is needed, but I'm not sure it's
sufficient: the register should be zero-extended, not sign-extended:

diff --git a/arch/x32/reloc.h b/arch/x32/reloc.h
index 7c72d26..492fbf1 100644
--- a/arch/x32/reloc.h
+++ b/arch/x32/reloc.h
@@ -23,4 +23,4 @@
 #define REL_TPOFF       R_X86_64_TPOFF64
 
 #define CRTJMP(pc,sp) __asm__ __volatile__( \
-	"mov %1,%%esp ; jmp *%0" : : "r"(pc), "r"(sp) : "memory" )
+	"mov %1,%%esp ; jmp *%q0" : : "r"(pc), "r"(sp) : "memory" )


Alexander


             reply	other threads:[~2015-04-20 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 19:21 Alexander Monakov [this message]
2015-04-20 21:13 ` Rich Felker
2015-04-20 21:30   ` Alexander Monakov
2015-04-20 22:00     ` Alexander Monakov
2015-04-20 23:56       ` Alexander Monakov
2015-04-21  1:35         ` Rich Felker
2015-04-21  7:30           ` Jens Gustedt
2015-04-21  8:56             ` Alexander Monakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.11.1504202204010.2677@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).