mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: x86_64 and x32 fail to build
Date: Tue, 21 Apr 2015 01:00:10 +0300 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.11.1504210054530.2677@monopod.intra.ispras.ru> (raw)
In-Reply-To: <alpine.LNX.2.11.1504210024100.2677@monopod.intra.ispras.ru>

Building x32 with --enable-warnings uncovers one leftover unused variable:

diff --git a/arch/x32/syscall_arch.h b/arch/x32/syscall_arch.h
index af67fe3..a3abcf5 100644
--- a/arch/x32/syscall_arch.h
+++ b/arch/x32/syscall_arch.h
@@ -45,7 +45,6 @@ static __inline long __syscall1(long long n, long long a1)
 static __inline long __syscall2(long long n, long long a1, long long a2)
 {
        unsigned long ret;
-       struct __timespec *ts2 = 0;
        switch (n) {
                __fixup_case_2;
        }


When building without --enable-warnings, there are many false positives from
-Wpointer-to-int-cast about x32 __scc(); at least from 4.5 onwards GCC enables
this warning by default, so perhaps if musl really wants to silence it, it
should test the corresponding -Wno-... flag outside of x$warnings == xyes
test?

Thanks.
Alexander


  reply	other threads:[~2015-04-20 22:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 19:21 Alexander Monakov
2015-04-20 21:13 ` Rich Felker
2015-04-20 21:30   ` Alexander Monakov
2015-04-20 22:00     ` Alexander Monakov [this message]
2015-04-20 23:56       ` Alexander Monakov
2015-04-21  1:35         ` Rich Felker
2015-04-21  7:30           ` Jens Gustedt
2015-04-21  8:56             ` Alexander Monakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.11.1504210054530.2677@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).