From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: Resuming work on new semaphore
Date: Thu, 23 Apr 2015 23:01:19 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.11.1504232253520.2677@monopod.intra.ispras.ru> (raw)
In-Reply-To: <alpine.LNX.2.11.1504232031340.2677@monopod.intra.ispras.ru>
I was over-eager in size-optimizing and at first didn't notice that we may not
report EOVERFLOW after successfully incrementing val[0]; therefore we can
reuse only the very end of the futex-wake path:
#define VAL0_MAX (SEM_VALUE_MAX/2+1)
#define VAL1_MAX (SEM_VALUE_MAX/2)
int sem_post(sem_t *sem)
{
int priv, old, val = sem->__val[0];
val -= val == VAL0_MAX;
while (old = val, (val = a_cas(sem->__val, val, val+1)) != old)
if (val == VAL0_MAX) {
priv = sem->__val[2];
do {
if ((val = sem->__val[1]) >= VAL1_MAX) {
errno = EOVERFLOW;
return -1;
}
} while (val != a_cas(sem->__val+1, val, val+1));
goto wake;
}
if (val < 0) {
priv = sem->__val[2];
a_inc(sem->__val+1);
wake:
__wake(sem->__val+1, 1, priv);
}
return 0;
}
Now instead of 'premature EOVERFLOW' problem we have the 'val[1] overshoot'
problem. It can lead to getvalue overflow:
1. Semaphore initialized to SEM_VALUE_MAX
2. Thread A downs val[0] to 0
3. Thread B downs val[0] to -1
4. Thread A calls sem_post: val[0] == 0, val[1] == VAL1_MAX+1
.. (thread B does not consume the post yet)
5. Thread A ups val[0] to VAL0_MAX
.. now getvalue returns INT_MIN
Alexander
next prev parent reply other threads:[~2015-04-23 20:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 1:30 Rich Felker
2015-04-02 7:42 ` Alexander Monakov
2015-04-02 15:26 ` Rich Felker
2015-04-02 21:39 ` Alexander Monakov
2015-04-02 23:14 ` Rich Felker
2015-04-05 14:07 ` Alexander Monakov
2015-04-05 14:17 ` Alexander Monakov
2015-04-05 19:02 ` Rich Felker
2015-04-05 20:03 ` Alexander Monakov
2015-04-05 20:23 ` Rich Felker
2015-04-05 21:07 ` Alexander Monakov
2015-04-11 22:22 ` Alexander Monakov
2015-04-23 16:06 ` Rich Felker
2015-04-23 18:24 ` Alexander Monakov
2015-04-23 20:01 ` Alexander Monakov [this message]
2015-04-24 2:46 ` Rich Felker
2015-04-24 10:23 ` Alexander Monakov
2015-04-24 15:03 ` Rich Felker
2015-04-24 15:47 ` Alexander Monakov
2015-04-24 15:59 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.11.1504232253520.2677@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).