From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/3] allow different size hash table entries
Date: Wed, 27 Jul 2016 19:49:51 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.13.1607271940490.21500@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20160726035300.10255-2-koorogi@koorogi.info>
On Mon, 25 Jul 2016, Bobby Bingham wrote:
> The sysv hash table for dynamic symbol lookups is supposed to always have
> 32 bit entries, but some architectures (alpha, s390x) botched the abi and
> use 64 bit entries. Despite this, the hash function is the same, and still
> only produces 32 bit hash values.
Note, Glibc does not specialize its lookup code for those platforms; instead,
they use user-visible type Elf_Symndx (exposed via link.h, also on musl) to
denote the type of hash table entries; Alpha and s390 override this type
appropriately in their arch-specific headers.
This suggests that musl should also define Elf_Symndx as a 64-bit type
(otherwise it's incompatible), and then dynlink.c admits a cleaner fix (i.e.
using Elf_Symndx where appropriate, without a new #ifndef).
HTH
Alexander
next prev parent reply other threads:[~2016-07-27 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 3:52 [PATCH 1/3] treat null vdso base same as missing Bobby Bingham
2016-07-26 3:52 ` [PATCH 2/3] allow different size hash table entries Bobby Bingham
2016-07-27 16:49 ` Alexander Monakov [this message]
2016-07-26 3:53 ` [PATCH 3/3] add s390x port Bobby Bingham
2016-10-21 20:27 ` Rich Felker
2016-10-22 0:15 ` Bobby Bingham
2016-10-22 2:59 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.1607271940490.21500@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).