From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10472 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix type for ifc_ifcu.ifcu_buf field of struct ifconf Date: Fri, 16 Sep 2016 11:12:14 +0300 (MSK) Message-ID: References: <20160915152731.4897-1-dsabogalcc@gmail.com> <20160915152731.4897-2-dsabogalcc@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1474013591 12671 195.159.176.226 (16 Sep 2016 08:13:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Sep 2016 08:13:11 +0000 (UTC) User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) To: musl@lists.openwall.com Original-X-From: musl-return-10485-gllmg-musl=m.gmane.org@lists.openwall.com Fri Sep 16 10:13:07 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkoGY-0001ZY-Fm for gllmg-musl@m.gmane.org; Fri, 16 Sep 2016 10:12:58 +0200 Original-Received: (qmail 32543 invoked by uid 550); 16 Sep 2016 08:12:58 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32525 invoked from network); 16 Sep 2016 08:12:57 -0000 In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:10472 Archived-At: On Thu, 15 Sep 2016, Daniel Sabogal wrote: > On Thu, Sep 15, 2016 at 4:25 PM, Alexander Monakov wrote: > > Declaration of 'ifru_data' in that header has the same issue. > > I originally considered changing this one but had left it out since > linux disagree on the type (void *). Ah. From looking at pre-git Linux history, it appears that it had 'char *', but then it was changed to 'void *' in June 2004 by commit '[PATCH] sparse: ->ifr_data annotation' by Al Viro, causing a divergence with the Glibc interface. FreeBSD also has 'char *' (caddr_t) there, and netdevice(7) manpage documents that the Linux interface has 'char *' as well. Thus, the kernel uapi header is the odd one out. Please wait for further feedback from Rich. Thanks. Alexander