[PATCH] configure: fix ctrl+C

[PATCH] configure: fix ctrl+C

[Laine Gholson]

[-- Attachment #1: Type: text/plain, Size: 136 bytes --]

the trap in the configure script doesn't exit like it should, fix that, and while I am at it, use rm -f to fix spurious errors from rm.

[-- Attachment #2: configure.patch --]
[-- Type: text/x-patch, Size: 661 bytes --]

From 69f5bbcc3369ee94a91458178f0660a16c73732b Mon Sep 17 00:00:00 2001
From: Laine Gholson <laine.gholson@gmail.com>
Date: Mon, 24 Oct 2016 20:48:18 -0500
Subject: [PATCH] configure: fix ctrl-c

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 707eb12..13afa22 100755
--- a/configure
+++ b/configure
@@ -214,7 +214,7 @@ tmpc="./conf$$-$PPID-$i.c"
 test "$i" -gt 50 && fail "$0: cannot create temporary file $tmpc"
 done
 set +C
-trap 'rm "$tmpc"' EXIT INT QUIT TERM HUP
+trap 'rm -f "$tmpc"; exit 1' EXIT INT QUIT TERM HUP
 
 #
 # Check whether we are cross-compiling, and set a default
-- 
2.10.1

Re: [PATCH] configure: fix ctrl+C

[Alexander Monakov]

On Mon, 24 Oct 2016, Laine Gholson wrote:

> the trap in the configure script doesn't exit like it should, fix that, and
> while I am at it, use rm -f to fix spurious errors from rm.

Did you observe such an error in practice? If so, I'm curious what it was, I
don't see how it can arise because "$tmpc" is created before the trap is
installed, and is not removed other than by the trap.

> --- a/configure
> +++ b/configure
> @@ -214,7 +214,7 @@ tmpc="./conf$$-$PPID-$i.c"
>  test "$i" -gt 50 && fail "$0: cannot create temporary file $tmpc"
>  done
>  set +C
> -trap 'rm "$tmpc"' EXIT INT QUIT TERM HUP
> +trap 'rm -f "$tmpc"; exit 1' EXIT INT QUIT TERM HUP
 

This will cause configure to exit with status 1 even on normal termination,
though.

Alexander