From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11490 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Handle localtime errors in ctime Date: Thu, 15 Jun 2017 20:03:30 +0300 (MSK) Message-ID: References: <1497545016-22965-1-git-send-email-oaanson@gmail.com> <20170615165413.GO1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1497546251 28389 195.159.176.226 (15 Jun 2017 17:04:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Jun 2017 17:04:11 +0000 (UTC) User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) To: musl@lists.openwall.com Original-X-From: musl-return-11503-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jun 15 19:04:07 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dLYBi-00077x-Tx for gllmg-musl@m.gmane.org; Thu, 15 Jun 2017 19:04:07 +0200 Original-Received: (qmail 13654 invoked by uid 550); 15 Jun 2017 17:04:10 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13410 invoked from network); 15 Jun 2017 17:03:41 -0000 In-Reply-To: <20170615165413.GO1627@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:11490 Archived-At: On Thu, 15 Jun 2017, Rich Felker wrote: > On Thu, Jun 15, 2017 at 07:43:36PM +0300, Omer Anson wrote: > > ctime passes the result from localtime directly to asctime. But in case > > of error, localtime returns 0. This causes an error (NULL pointer > > dereference) in asctime. > > > > According to the man pages [1], ctime should also return 0 upon error. > > Therefore, if localtime fails (return 0), ctime also returns 0. > > > > [1] https://linux.die.net/man/3/ctime > Content looks good. Making minor edits for style and I'll commit. Um, the previous time an opposite direction was taken: http://www.openwall.com/lists/musl/2014/09/05/17 Alexander