From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11517
Path: news.gmane.org!.POSTED!not-for-mail
From: Alexander Monakov <amonakov@ispras.ru>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH] fix arm run-time abi string functions
Date: Sun, 18 Jun 2017 22:05:59 +0300 (MSK)
Message-ID: <alpine.LNX.2.20.13.1706182201560.21867@monopod.intra.ispras.ru>
References: <20170221011506.GO12395@port70.net> <alpine.LNX.2.20.13.1706181508061.21867@monopod.intra.ispras.ru> <20170618185007.GI27071@port70.net>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Trace: blaine.gmane.org 1497812776 32403 195.159.176.226 (18 Jun 2017 19:06:16 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sun, 18 Jun 2017 19:06:16 +0000 (UTC)
User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14)
To: musl@lists.openwall.com
Original-X-From: musl-return-11530-gllmg-musl=m.gmane.org@lists.openwall.com Sun Jun 18 21:06:08 2017
Return-path: <musl-return-11530-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by blaine.gmane.org with smtp (Exim 4.84_2)
	(envelope-from <musl-return-11530-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1dMfWR-0007x1-N4
	for gllmg-musl@m.gmane.org; Sun, 18 Jun 2017 21:06:07 +0200
Original-Received: (qmail 16063 invoked by uid 550); 18 Jun 2017 19:06:11 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 16045 invoked from network); 18 Jun 2017 19:06:10 -0000
In-Reply-To: <20170618185007.GI27071@port70.net>
Xref: news.gmane.org gmane.linux.lib.musl.general:11517
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/11517>

On Sun, 18 Jun 2017, Szabolcs Nagy wrote:
> > here it's possible to hoist and deduplicate 'cmp r2, #0; bxeq lr' by placing it
> > prior to the direction check.
> > 
> 
> i dont think there is a difference
> (either way, both functions need to do this cmp once,
> the executed insns are the same you just changed the
> ordering a bit)

I was pointing that out as a size optimization, but depending on alignment
of the following code it might be pointless indeed.

Alexander