From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11620 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix undefined behavior in ptrace Date: Wed, 28 Jun 2017 18:22:12 +0300 (MSK) Message-ID: References: <20170628132513.15483-1-amonakov@ispras.ru> <20170628151328.GD1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1498663349 22754 195.159.176.226 (28 Jun 2017 15:22:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Jun 2017 15:22:29 +0000 (UTC) User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) To: musl@lists.openwall.com Original-X-From: musl-return-11633-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 28 17:22:23 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dQEnO-0005a9-8z for gllmg-musl@m.gmane.org; Wed, 28 Jun 2017 17:22:22 +0200 Original-Received: (qmail 3073 invoked by uid 550); 28 Jun 2017 15:22:25 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 2031 invoked from network); 28 Jun 2017 15:22:25 -0000 In-Reply-To: <20170628151328.GD1627@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:11620 Archived-At: On Wed, 28 Jun 2017, Rich Felker wrote: > I think there's still UB here, reading more args than were passed. > These calls to va_arg should probably be dependent on the particular > req; I don't see any reason for it to be compile-time dependent on the > presence of one particular req value. I raised that last year but there was no response: http://www.openwall.com/lists/musl/2016/05/04/18 Alexander