From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: [RFC PATCH] Allow annotating calloc for Valgrind
Date: Fri, 30 Jun 2017 02:42:53 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.13.1706300236230.18055@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20170629232032.GH1627@brightrain.aerifal.cx>
On Thu, 29 Jun 2017, Rich Felker wrote:
> Use of valgrind annotation was already rejected a long time ago.
I don't see any record of that in the archives...
> The same can be done with a suppressions file and that's where it belongs.
What would you write in the suppression file? If you tell Valgrind to ignore
branch-on-uninit in calloc, it will report errors later on anyway when the
application reads from the calloc'ed region. Szabolcs went down that road once.
> The same could be achieved without hacks just using #if/#ifdef around
> the #include. But I don't see how <memcheck.h> could work anyway; musl
> obviously does not, and can't, use any host include paths where a
> header might already be installed.
With an appropriate -I in CPPFLAGS?
Alexander
next prev parent reply other threads:[~2017-06-29 23:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 22:56 Alexander Monakov
2017-06-29 23:20 ` Rich Felker
2017-06-29 23:42 ` Alexander Monakov [this message]
2017-06-29 23:56 ` Rich Felker
2017-07-02 13:55 ` Alexander Monakov
2017-07-02 14:35 ` Rich Felker
2017-07-02 16:16 ` Alexander Monakov
2017-07-02 16:31 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.1706300236230.18055@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).