From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11631 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [RFC PATCH] Allow annotating calloc for Valgrind Date: Fri, 30 Jun 2017 02:42:53 +0300 (MSK) Message-ID: References: <20170629225614.19061-1-amonakov@ispras.ru> <20170629232032.GH1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1498779790 19155 195.159.176.226 (29 Jun 2017 23:43:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Jun 2017 23:43:10 +0000 (UTC) User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) To: musl@lists.openwall.com Original-X-From: musl-return-11644-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 30 01:43:06 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1dQj5U-0004fq-Uj for gllmg-musl@m.gmane.org; Fri, 30 Jun 2017 01:43:05 +0200 Original-Received: (qmail 13830 invoked by uid 550); 29 Jun 2017 23:43:08 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 13785 invoked from network); 29 Jun 2017 23:43:06 -0000 In-Reply-To: <20170629232032.GH1627@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:11631 Archived-At: On Thu, 29 Jun 2017, Rich Felker wrote: > Use of valgrind annotation was already rejected a long time ago. I don't see any record of that in the archives... > The same can be done with a suppressions file and that's where it belongs. What would you write in the suppression file? If you tell Valgrind to ignore branch-on-uninit in calloc, it will report errors later on anyway when the application reads from the calloc'ed region. Szabolcs went down that road once. > The same could be achieved without hacks just using #if/#ifdef around > the #include. But I don't see how could work anyway; musl > obviously does not, and can't, use any host include paths where a > header might already be installed. With an appropriate -I in CPPFLAGS? Alexander