From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12433 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] faccessat: fix error code on setreXid failure Date: Wed, 31 Jan 2018 01:20:45 +0300 (MSK) Message-ID: References: <20180130203237.4580-1-amonakov@ispras.ru> <20180130213353.GM1627@brightrain.aerifal.cx> <20180130220737.GN1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1517350740 25703 195.159.176.226 (30 Jan 2018 22:19:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2018 22:19:00 +0000 (UTC) User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) To: musl@lists.openwall.com Original-X-From: musl-return-12449-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jan 30 23:18:56 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1egeEw-0006L6-93 for gllmg-musl@m.gmane.org; Tue, 30 Jan 2018 23:18:54 +0100 Original-Received: (qmail 14223 invoked by uid 550); 30 Jan 2018 22:20:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 14198 invoked from network); 30 Jan 2018 22:20:56 -0000 In-Reply-To: <20180130220737.GN1627@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:12433 Archived-At: On Tue, 30 Jan 2018, Rich Felker wrote: > > We know we are not tracing this child, and stop notifications are only > > delivered if WUNTRACED is given in flags, aren't they? > > I'm not sure what can happen if it's all running under strace -f or > something. And I'm not sure what the conditions for stop notifications > are. If it's assured that they can't happen then maybe the loop can be > removed. Well, currently musl is just inconsistent, as in other instance(s?) (most notably in posix_spawn) it makes a single call to waitpid without retrying even though the same concerns apply. Alexander