From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12457 Path: news.gmane.org!.POSTED!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v2] track pthread stack guard sizes Date: Mon, 5 Feb 2018 19:18:44 +0300 (MSK) Message-ID: References: <20180202200855.1514-1-nenolod@dereferenced.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1517847456 19875 195.159.176.226 (5 Feb 2018 16:17:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2018 16:17:36 +0000 (UTC) User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) To: musl@lists.openwall.com Original-X-From: musl-return-12473-gllmg-musl=m.gmane.org@lists.openwall.com Mon Feb 05 17:17:32 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1eijRy-0002p4-0M for gllmg-musl@m.gmane.org; Mon, 05 Feb 2018 17:16:58 +0100 Original-Received: (qmail 17998 invoked by uid 550); 5 Feb 2018 16:18:56 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 17977 invoked from network); 5 Feb 2018 16:18:55 -0000 In-Reply-To: <20180202200855.1514-1-nenolod@dereferenced.org> Xref: news.gmane.org gmane.linux.lib.musl.general:12457 Archived-At: On Fri, 2 Feb 2018, William Pitcock wrote: > --- a/src/internal/pthread_impl.h > +++ b/src/internal/pthread_impl.h > @@ -46,6 +46,7 @@ struct pthread { > char *dlerror_buf; > int dlerror_flag; > void *stdio_locks; > + size_t guard_size; > uintptr_t canary_at_end; > void **dtv_copy; > }; Doesn't this break SSP on powerpc and powerpc64 by changing offset of 'canary_at_end'? If not, can you please mention why in the commit message? Alexander