mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: FE Exception triggered by comparison
Date: Wed, 27 Feb 2019 22:48:02 +0300 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.20.13.1902272229540.30425@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20190227172641.GW23599@brightrain.aerifal.cx>

On Wed, 27 Feb 2019, Rich Felker wrote:

> Or left-shifting rather than masking to get rid of the sign bit?
> That's all it's doing. I don't think right-shift is okay since losing
> any low bits would break the comparison.

Right, thanks. Make it a rotate then: with a rotate you can place the
exponent in the least significant bits, then force sign bit to 1 and
compare against a small immediate.

(note that on 32-bit this bit test makes a mess for doubles anyhow)

> > but even then
> > I'd say the "native" version is preferable.
> 
> I suspect this is probably true, though I also worry a bit whether
> there are archs where it does something inefficient or broken.
> 
> Ideally the compiler would be able to recognize portable (within IEEE)
> patterns for floating point representation examination and optimize
> them if there's a more efficient way to be able to do it for a
> particular machine.

There's a difference for sNaN operands: the bit-test version obviously
is not going to raise "invalid", while comparing the fpu register with
itself will.  So I'm afraid the compiler wouldn't do that for x86 (but
could for targets where an suitable instruction is available).

Alexander


  parent reply	other threads:[~2019-02-27 19:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-24 13:28 Damian McGuckin
2019-02-24 17:12 ` Markus Wichmann
2019-02-24 19:25 ` Szabolcs Nagy
2019-02-24 20:04   ` Jens Gustedt
2019-02-24 21:50     ` Damian McGuckin
2019-02-25  5:21       ` Damian McGuckin
2019-02-25 15:51       ` Markus Wichmann
2019-02-26  3:55         ` Damian McGuckin
2019-02-27 14:14           ` Alexander Monakov
2019-02-27 15:38             ` Damian McGuckin
2019-02-27 16:00               ` Alexander Monakov
2019-02-27 16:09                 ` Damian McGuckin
2019-02-27 16:14                   ` Markus Wichmann
2019-02-27 16:20                     ` Damian McGuckin
2019-02-28  1:07                     ` Damian McGuckin
2019-02-28  1:27                       ` Rich Felker
2019-02-28  2:28                         ` Damian McGuckin
2019-02-27 16:32                   ` Alexander Monakov
2019-02-27 16:42                     ` Rich Felker
2019-02-27 17:08                       ` Szabolcs Nagy
2019-02-27 17:14                       ` Alexander Monakov
2019-02-27 17:26                         ` Rich Felker
2019-02-27 19:36                           ` Szabolcs Nagy
2019-02-27 19:48                           ` Alexander Monakov [this message]
2019-02-27 20:16                             ` Szabolcs Nagy
2019-02-27 20:35                               ` Rich Felker
2019-02-27 21:03                                 ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.20.13.1902272229540.30425@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).