From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by inbox.vuxu.org (OpenSMTPD) with SMTP id 7c6950dd for ; Thu, 6 Feb 2020 17:15:43 +0000 (UTC) Received: (qmail 27868 invoked by uid 550); 6 Feb 2020 17:15:42 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 27850 invoked from network); 6 Feb 2020 17:15:41 -0000 Date: Thu, 6 Feb 2020 20:15:30 +0300 (MSK) From: Alexander Monakov To: musl@lists.openwall.com In-Reply-To: <20200206145156.GF1663@brightrain.aerifal.cx> Message-ID: References: <20200114185058.GV23985@port70.net> <20200114185835.GG30412@brightrain.aerifal.cx> <20200206145156.GF1663@brightrain.aerifal.cx> User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [musl] Q: dealing with missing removal of excess precision On Thu, 6 Feb 2020, Rich Felker wrote: > I think I might like to go ahead and apply these patches now, or at > least some of them -- the ones fixing excess precision -- rather > waiting, because I got a report of a nasty bug stemming from excess > precision of the inverse trig functions: That might be exactly the empty set of patches, as I did not yet post any for functions that might return with excess precision. Be advised that I found bugs in my patches, so given that no one so far has pointed them out on the mailing list indicates that either nobody bothered to review, or people are keeping the findings to themselves. > If writing and testing the remaining i386 functions before release is > not practical, I wonder if just removing the asm for now, and adding > back the new code in next release cycle would be a good idea. Or I > could just leave it, but I don't like making a release with "known > bugs of consequence" like this. I think fixing excess precision in inverse trig functions might be easier than removing the asm entirely. Alexander