mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH 1/3] setjmp: fix x86-64 longjmp argument adjustment
Date: Thu, 13 Aug 2020 11:53:58 +0300 (MSK)	[thread overview]
Message-ID: <alpine.LNX.2.20.13.2008131148050.7727@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20200813100120.5bb689e8@inria.fr>



On Thu, 13 Aug 2020, Jens Gustedt wrote:

> Alexander,
> probably this has nothing to do with the issue at hand but 
> 
> on Wed, 12 Aug 2020 16:29:59 +0300 (MSK) you (Alexander Monakov
> <amonakov@ispras.ru>) wrote:
> 
> >         int v = setjmp(jb);
> 
> is a use of `setjmp` that is not conforming. `setjmp` is only allowed
> either standalone or as controlling expression either directly or
> negated.

Thanks. Yeah, this is a moot point as the test needs GCC with -O anyway, and
GCC allows setjmp in any context. But nevertheless it's easy to adjust it
by changing the offending line to 'if (setjmp(jb)) return 0;' and changing
the final 'return !v'  to 'return 1'.

Alexander

  reply	other threads:[~2020-08-13  8:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 18:11 Alexander Monakov
2020-08-11 18:11 ` [musl] [PATCH 2/3] setjmp: avoid useless REX-prefix on xor %eax, %eax Alexander Monakov
2020-08-11 18:11 ` [musl] [PATCH 3/3] setjmp: optimize x86 longjmp epilogues Alexander Monakov
2020-08-11 18:45 ` [musl] [PATCH 1/3] setjmp: fix x86-64 longjmp argument adjustment Rich Felker
2020-08-12 13:29   ` Alexander Monakov
2020-08-12 21:44     ` Szabolcs Nagy
2020-08-12 22:13       ` Szabolcs Nagy
2020-08-13  8:01     ` Jens Gustedt
2020-08-13  8:53       ` Alexander Monakov [this message]
2020-08-11 23:10 ` [musl] [PATCH] setjmp: optimize x86-64 longjmp prologues Alexander Monakov
2020-08-12 11:34   ` [musl] [PATCH 4/3] setjmp: optimize " Alexander Monakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.20.13.2008131148050.7727@monopod.intra.ispras.ru \
    --to=amonakov@ispras.ru \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).