From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Cc: Theodore Dubois <tblodt@icloud.com>
Subject: Re: [musl] i386 __set_thread_area will crash if the syscall fails
Date: Mon, 31 Aug 2020 09:55:37 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.13.2008310951460.18674@monopod.intra.ispras.ru> (raw)
In-Reply-To: <20200831010710.GH3265@brightrain.aerifal.cx>
On Sun, 30 Aug 2020, Rich Felker wrote:
> > Tangentially, I'm not sure why this file has so many hardcoded magic
> > numbers and no comments to explain what they are.
>
> Really it shouldn't even be external asm anymore. I'm trying to move
> as much external asm as possible to inline asm written in C, and this
> could be written entirely with __syscall() after #define
> SYSCALL_NO_TLS (recently added) and all the structures setup
> explicitly in C. I'll take a stab at doing that after fixing the bug.
I also would like an answer to a question about utter lack of comments
that your response did not directly address. This is an issue in
specialized asm implementations of math functions too, for instance.
Alexander
next prev parent reply other threads:[~2020-08-31 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 0:34 Theodore Dubois
2020-08-31 1:07 ` Rich Felker
2020-08-31 1:41 ` Rich Felker
2020-08-31 2:51 ` Rich Felker
2020-09-01 18:20 ` Markus Wichmann
2020-08-31 6:55 ` Alexander Monakov [this message]
2020-08-31 12:36 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.2008310951460.18674@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
--cc=tblodt@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).