From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9412 Path: news.gmane.org!not-for-mail From: Alexander Monakov Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] add sched_getcpu Date: Mon, 29 Feb 2016 23:10:51 +0300 (MSK) Message-ID: References: <1456765028-23958-1-git-send-email-nathan@nathan7.eu> <1456765216-24883-1-git-send-email-nathan@nathan7.eu> <20160229183816.GB9349@brightrain.aerifal.cx> <20160229200500.GC9349@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1456776671 4717 80.91.229.3 (29 Feb 2016 20:11:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Feb 2016 20:11:11 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9425-gllmg-musl=m.gmane.org@lists.openwall.com Mon Feb 29 21:11:09 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aaU9p-0003Iv-11 for gllmg-musl@m.gmane.org; Mon, 29 Feb 2016 21:11:05 +0100 Original-Received: (qmail 30712 invoked by uid 550); 29 Feb 2016 20:11:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30694 invoked from network); 29 Feb 2016 20:11:02 -0000 In-Reply-To: <20160229200500.GC9349@brightrain.aerifal.cx> User-Agent: Alpine 2.20 (LNX 67 2015-01-07) Xref: news.gmane.org gmane.linux.lib.musl.general:9412 Archived-At: On Mon, 29 Feb 2016, Rich Felker wrote: > > > Policy is to always include the header with the public declaration > > > (and any feature test macros necessary to get it) so that the compiler > > > checks the implementation against the public declaration. > > > > This policy certain makes sense; I pointed that out because I've seen it > > violated; at least the following files violate it by defining something > > without including anything: [snip] > > src/internal/procfdname.c > > This is an internal function. Please explain the difference in policy for internal functions. The original motivation (compiler checking the prototype) sounds like it's valuable for internal functions too. Thanks. Alexander