From: Alexander Monakov <amonakov@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: [PATCH] add sched_getcpu
Date: Mon, 29 Feb 2016 23:17:07 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.1602292311050.14767@monopod.intra.ispras.ru> (raw)
In-Reply-To: <CANHaCV+Z_PtCWC8Vme_7CVT6AHk6tKZKupDR9SQvrTWpheGAvg@mail.gmail.com>
> > As far as I can tell, syscall() is supposed to set errno (using
> > __sycall_ret), but maybe src/misc/syscall.c isn't what I think it is?
> >
> I indeed got the return value backwards, and I'll fix that, along with the
> > #ifdef.
> >
> Actually, nope, that ternary is the right way round, and __sycall_ret
> handles the -1 return.
Ah, indeed my original objection was wrong; however please note that you're
not calling syscall from src/misc/syscall.c here; it's #defined in
src/internal/syscall.h to __syscall_ret(__syscall(...)), and the typical usage
in musl internally is either tailcalling to syscall, or calling __syscall
where handling provided by __syscall_ret is not useful.
I'd recommend using __syscall and __syscall_ret here.
Alexander
next prev parent reply other threads:[~2016-02-29 20:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 16:49 Nathan Zadoks
2016-02-29 16:57 ` Nathan Zadoks
2016-02-29 16:57 ` Nathan Zadoks
2016-02-29 17:00 ` Nathan Zadoks
2016-02-29 17:23 ` Alexander Monakov
2016-02-29 17:33 ` Alexander Monakov
2016-03-01 13:45 ` [PATCH] add sched_getcpu, with vDSO support Nathan Zadoks
2016-03-01 15:56 ` Nathan Zadoks
2016-03-02 5:55 ` Rich Felker
2016-03-02 16:26 ` [PATCH 0/2] add sched_getcpu, take n+1 Nathan Zadoks
2016-03-02 16:26 ` [PATCH 1/2] add sched_getcpu Nathan Zadoks
2016-03-02 16:26 ` [PATCH 2/2] add sched_getcpu vDSO support Nathan Zadoks
2016-03-03 3:01 ` [PATCH 0/2] add sched_getcpu, take n+1 Rich Felker
2016-02-29 17:49 ` [PATCH] add sched_getcpu nathan
2016-02-29 17:52 ` nathan
2016-02-29 20:17 ` Alexander Monakov [this message]
2016-02-29 20:49 ` Nathan Zadoks
2016-02-29 18:38 ` Rich Felker
2016-02-29 19:59 ` Alexander Monakov
2016-02-29 20:05 ` Rich Felker
2016-02-29 20:10 ` Alexander Monakov
2016-02-29 20:17 ` Rich Felker
2016-02-29 21:09 ` Tomasz Sterna
2016-02-29 21:21 ` Nathan Zadoks
2016-02-29 21:30 ` Rich Felker
2016-03-01 20:35 ` Tomasz Sterna
2016-03-01 22:34 ` Rich Felker
2016-03-02 20:46 ` Tomasz Sterna
2016-03-02 21:19 ` Szabolcs Nagy
2016-03-02 23:26 ` Rich Felker
2016-03-04 22:21 ` Tomasz Sterna
2016-03-04 23:33 ` Rich Felker
2016-03-05 11:40 ` Tomasz Sterna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.1602292311050.14767@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).