From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9714
Path: news.gmane.org!not-for-mail
From: Alexander Monakov <amonakov@ispras.ru>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH 1/3] overhaul environment functions
Date: Sun, 20 Mar 2016 23:15:27 +0300 (MSK)
Message-ID: <alpine.LNX.2.20.1603202310240.10468@monopod.intra.ispras.ru>
References: <1457895230-13602-1-git-send-email-amonakov@ispras.ru> <1457895230-13602-2-git-send-email-amonakov@ispras.ru> <20160319164624.GW21636@brightrain.aerifal.cx> <alpine.LNX.2.20.1603192015120.10468@monopod.intra.ispras.ru> <20160320002356.GX21636@brightrain.aerifal.cx>
 <alpine.LNX.2.20.1603200708060.10468@monopod.intra.ispras.ru> <20160320195655.GA21636@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Trace: ger.gmane.org 1458504949 27106 80.91.229.3 (20 Mar 2016 20:15:49 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 20 Mar 2016 20:15:49 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-9727-gllmg-musl=m.gmane.org@lists.openwall.com Sun Mar 20 21:15:44 2016
Return-path: <musl-return-9727-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-9727-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1ahjlG-0003w8-ET
	for gllmg-musl@m.gmane.org; Sun, 20 Mar 2016 21:15:42 +0100
Original-Received: (qmail 19522 invoked by uid 550); 20 Mar 2016 20:15:39 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 19504 invoked from network); 20 Mar 2016 20:15:38 -0000
In-Reply-To: <20160320195655.GA21636@brightrain.aerifal.cx>
User-Agent: Alpine 2.20 (LNX 67 2015-01-07)
Xref: news.gmane.org gmane.linux.lib.musl.general:9714
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/9714>

On Sun, 20 Mar 2016, Rich Felker wrote:
> After debunking most of my concerns, are there any things left to
> change in patch 1, or should I go ahead and apply it?

Let me send a v2 with two changes: reinstating setenv EINVAL on null arg,
and tweaking unsetenv like I mentioned. Should be good with those changes,
I think.

Thanks.
Alexander