From: Damian McGuckin <damianm@esi.com.au>
To: Szabolcs Nagy <nsz@port70.net>
Cc: musl@lists.openwall.com
Subject: Re: Possible Mistype in exp.c
Date: Wed, 30 Jan 2019 23:56:05 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.02.1901302320110.28837@key0.esi.com.au> (raw)
In-Reply-To: <20190130093738.GE21289@port70.net>
I have Muller's book. Good for the math. Not for any ideas about the
actual implementation.
As a matter of interest, what was the benchmark against which you get a 2x
speed gain?
I got 1.75 against GLIBC for what that is worth. I used a faster scaling
routine. But I was not chasing a improved ULP performance ike you were as
that was too much extra work. Your work there sounds like seriously smart
stuff to me.
I used super-scalar friendly code which adds an extra multiplication. It
made a miniscule tiny net benefit on the Xeons (not Xeon Gold).
I had 2 versions of the fast scaling routine replacing ldexp. One used a
single ternary if/then/else and other grabbed the sign and did a table
looking which meant one extra multiplication all the time but no branches.
The one extra multiplication instead of a branch in the 2-line scaling
routine made no difference.
I saw a tiny but measurable difference when I used a Xeon with an FMA
compared to one which did not.
Discarding the last term in the SUN routine and that net loss of one
multiplication still made no serious difference to the timing and of
course, the results were affected.
My timings showed on my reworked code (for doubles)
21+% the preliminary comparisons
43+% polynomial computation super-scalar friendly way
35+% y = 1 + (x*c/(2-c) - lo + hi);
return k == 0 ? y : scalbn-FAST(y, k);
I have slightly increased the work load in the comparisons because I avoid
pulling 'x' apart into 'hx'. I used only doubles or floats.
Regards - Damian
Pacific Engineering Systems International, 277-279 Broadway, Glebe NSW 2037
Ph:+61-2-8571-0847 .. Fx:+61-2-9692-9623 | unsolicited email not wanted here
Views & opinions here are mine and not those of any past or present employer
next prev parent reply other threads:[~2019-01-30 12:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 6:59 Damian McGuckin
2019-01-29 11:01 ` Szabolcs Nagy
2019-01-29 11:26 ` Damian McGuckin
2019-01-29 11:43 ` Szabolcs Nagy
2019-01-30 1:18 ` Damian McGuckin
2019-01-30 9:37 ` Szabolcs Nagy
2019-01-30 11:14 ` Damian McGuckin
2019-01-30 12:19 ` Szabolcs Nagy
2019-01-30 12:44 ` Alexander Monakov
2019-01-30 14:10 ` Szabolcs Nagy
2019-02-01 23:26 ` Morten Welinder
2019-02-02 3:39 ` Szabolcs Nagy
2019-02-03 2:05 ` Morten Welinder
2019-02-03 3:07 ` Damian McGuckin
2019-04-03 1:13 ` Floating Point Accuracy Damian McGuckin
2019-01-30 12:56 ` Damian McGuckin [this message]
2019-01-31 0:04 ` Possible Mistype in exp.c Szabolcs Nagy
2019-01-31 0:39 ` Damian McGuckin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.1901302320110.28837@key0.esi.com.au \
--to=damianm@esi.com.au \
--cc=musl@lists.openwall.com \
--cc=nsz@port70.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).