From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <musl-return-15356-ml=inbox.vuxu.org@lists.openwall.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2
Received: from mother.openwall.net (mother.openwall.net [195.42.179.200])
	by inbox.vuxu.org (OpenSMTPD) with SMTP id 1bfa04a5
	for <ml@inbox.vuxu.org>;
	Sun, 2 Feb 2020 00:47:58 +0000 (UTC)
Received: (qmail 24208 invoked by uid 550); 2 Feb 2020 00:47:55 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 24190 invoked from network); 2 Feb 2020 00:47:54 -0000
X-Authentication-Warning: key0.esi.com.au: damianm owned process doing -bs
Date: Sun, 2 Feb 2020 11:47:38 +1100 (AEDT)
From: Damian McGuckin <damianm@esi.com.au>
To: musl@lists.openwall.com
In-Reply-To: <20200125001100.GY30412@brightrain.aerifal.cx>
Message-ID: <alpine.LRH.2.02.2002021142090.12885@key0.esi.com.au>
References: <alpine.LRH.2.02.2001181545420.21223@key0.esi.com.au> <20200118053759.GX30412@brightrain.aerifal.cx> <20200118094015.GE23985@port70.net> <alpine.LRH.2.02.2001240755500.28245@key0.esi.com.au> <20200124011122.GP30412@brightrain.aerifal.cx>
 <alpine.LRH.2.02.2001241227030.6298@key0.esi.com.au> <20200124045554.GR30412@brightrain.aerifal.cx> <alpine.LRH.2.02.2001241604050.13947@key0.esi.com.au> <20200124134402.GS30412@brightrain.aerifal.cx> <alpine.LRH.2.02.2001251055530.14796@key0.esi.com.au>
 <20200125001100.GY30412@brightrain.aerifal.cx>
User-Agent: Alpine 2.02 (LRH 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Subject: Re: [musl] Considering x86-64 fenv.s to C


Questions of style:

When working inside 'fenv.c', what should internal routines and
definition be called to avoid namespace pollution, retain clarity,
and so on.

Note that 'fenv.c' is designed to never call any routines external to 
itself.

Do we keep using

 	FE_<SOMETHING>

and
 	fe<SOMETHING>

where <SOMETHING> is some meaningful name,

to conform to the external interface which we assume will never clash.

Or do we use

 	__<SOMETHING>

as is used or

 	__flt_rounds

which is used by FTL_ROUNDS when recovering the current IEEE 754 rounding 
style, as opposed to the architecture dependent one.

Thanks - Damian

Pacific Engineering Systems International, 277-279 Broadway, Glebe NSW 2037
Ph:+61-2-8571-0847 .. Fx:+61-2-9692-9623 | unsolicited email not wanted here
Views & opinions here are mine and not those of any past or present employer