From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id D9AAB253AA for ; Fri, 23 Feb 2024 04:26:49 +0100 (CET) Received: (qmail 11387 invoked by uid 550); 23 Feb 2024 03:23:23 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 11331 invoked from network); 23 Feb 2024 03:23:22 -0000 From: Hongliang Wang To: Rich Felker , musl@lists.openwall.com References: <20240125174353.GW22081@brightrain.aerifal.cx> <20240129164702.GR4163@brightrain.aerifal.cx> Message-ID: Date: Fri, 23 Feb 2024 11:26:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8Bx8ORhENhlJXI_AA--.34662S3 X-CM-SenderInfo: pzdqwxxrqjzxhdqjqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoWxJw4UXw47JF1kZryxuw4rJFc_yoWruw1UpF WFvay5KrWUGr1kJw1Utw1UXFy0kr18Xa15Xan5GFy8Kr45ZF1jvr1UXr4Y9F47Xr48GF4Y vr1Y9347uFZrXFcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr 0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzsqW UUUUU Subject: Re: [musl] loongarch64 merge Hi, Rich We are very excited to see that LoongArch has been merged in musl. Next, we will continue to work hard to improve LoongArch, and we still require your strong support. Thank you for your help on LoongArch. Regards, Hongliang Wang 在 2024/1/30 下午3:35, Hongliang Wang 写道: > > > 在 2024/1/30 上午12:47, Rich Felker 写道: >> On Thu, Jan 25, 2024 at 12:43:54PM -0500, Rich Felker wrote: >>> I'm going through where everything was left on this topic and >>> preparing a patch for merge. This message/thread is to document what >>> I'm actually doing vs the various submitted versions of the patch >>> since v5/v6 where the major review took place. >>> >>> >>> Subsequent changes I'm reverting: >>> >>> - De-optimization of __get_tp. No motivation for removing the >>>    potentially in-place $tp was provided, and we generally use the >>>    arch's tp in-place unless there's a compiler bug to be worked >>>    around. See powerpc{,64} for an example where it's used, or1k where >>>    we have a probably-obsolete workaround for ancient clang being >>>    broken. >>> >>> - unsigned -> unsigned int, etc. >>> >>> - Gratuitous whitespace changes in headers that obscure the fact that >>>    a header is a complete duplicate that could eventually be shared >>>    between archs (e.g. bits/float.h, bits/posix.h) or just obscure >>>    what differs from other archs when running diff. >>> >>> >>> Fixes from previous review that were overlooked: >>> >>> - Removing SA_RESTORER -- its presence defined as 0 produces wrong >>>    sigaction ABI. >>> >>> >>> Additions: >>> >>> - Adding the reloc.h/configure case for single-only float. >>> >>> - The new member names for mcontext_t are all in reserved namespace, >>>    so there's no reason to have a separate namespace-clean version of >>>    mcontext_t, and I'm removing the latter. >>> >>> - Public member uc_flags with no __, macro for compat with any >>>    existing software using the __-prefixed name. >>> >>> >>> Still TODO: >>> >>> I don't think I ever reviewed the apparent rewrite of sigsetjmp and >>> possibly some other asm that changed between v5 and v8. I'm about to >>> start looking at that and will follow up. >> >> OK, sigsetjmp appears to have been non-working in v5 (it failed to >> save the argument anywhere, so attempted it use it after it was >> clobbered in the code path after calling setjmp). >> >> v8 fixes this and seems like it should work, but I don't understand >> the offsets used. >> >> The loongarch64 __jmp_buf has 23 slots, but only appears to use 21 of >> them, with sigsetjmp storing its extra data in the last 2 unused >> slots. The contract here is supposed to be that the entirety of >> __jmp_buf belongs to setjmp/longjmp, with sigsetjmp using the extra >> space in the full jmp_buf/sigjmp_buf type with signal mask and lots of >> extra space. >> >> Were these slots added just for sigsetjmp? If so, that was an ABI >> mistake, but I don't think it warrants a late change; it's probably >> better to just leave them there as extensibility. > > Yes, the purpose of the last 2 slots of __jmp_buf just used for > sigsetjmp to storing its extra data. > Now leave them there as extensibility is OK. > > Hongliang Wang > >> >> Either way, I think sigsetjmp should be modified not to rely on >> storage in space that setjmp is entitled to be able to modify, i.e. it >> should be using offsets 184 and 184+16, not 168 and 176. >> >> Rich >> > I understand. I attached a patch to fix this issue. please review it. > > diff --git a/src/signal/loongarch64/sigsetjmp.s > b/src/signal/loongarch64/sigsetjmp.s > index 992ab1a4..9c0e3ae2 100644 > --- a/src/signal/loongarch64/sigsetjmp.s > +++ b/src/signal/loongarch64/sigsetjmp.s > @@ -5,8 +5,8 @@ >  sigsetjmp: >  __sigsetjmp: >         beq     $a1, $zero, 1f > -       st.d    $ra, $a0, 168 > -       st.d    $s0, $a0, 176 > +       st.d    $ra, $a0, 184 > +       st.d    $s0, $a0, 200  #184+8+8 >         move    $s0, $a0 > >         la.global  $t0, setjmp > @@ -14,8 +14,8 @@ __sigsetjmp: > >         move    $a1, $a0        # Return from 'setjmp' or 'longjmp' >         move    $a0, $s0 > -       ld.d    $ra, $a0, 168 > -       ld.d    $s0, $a0, 176 > +       ld.d    $ra, $a0, 184 > +       ld.d    $s0, $a0, 200 #184+8+8 > >  .hidden __sigsetjmp_tail >         la.global  $t0, __sigsetjmp_tail > (END) > > Hongliang Wang