Re: [musl] [PATCH 1/1] riscv64: add optimized memset, memcpy and memmove

[Pincheng Wang <pincheng.plct@isrc.iscas.ac.cn>]

Hi mirabilos,

Thank you for the review.

On 2025/11/14 07:15, Thorsten Glaser wrote:
> On Fri, 14 Nov 2025, Pincheng Wang wrote:
> 
>> +/* string function pointer, runtime-dispatched based on RVV support */
>> +__attribute__((visibility("hidden")))
>> +#ifndef __riscv_vector
>> +void *(*__memset_ptr)(void *, int, size_t) = __memset_scalar;
>> +void *(*__memcpy_ptr)(void *, const void *, size_t) = __memcpy_scalar;
>> +void *(*__memmove_ptr)(void *, const void *, size_t) = __memmove_scalar;
>> +#else
>> +void *(*__memset_ptr)(void *, int, size_t) = __memset_vect;
>> +void *(*__memcpy_ptr)(void *, const void *, size_t) = __memcpy_vect;
>> +void *(*__memmove_ptr)(void *, const void *, size_t) = __memmove_vect;
>> +#endif
> 
> You’d need to put the visibility attribute to each of these.
> 
> Why not just make them static (file-local), though?
> 

These function pointer variables do not need external linkage,so I will 
make them static in the next revision and drop the visibility attributes 
accordingly.

Best regards,
Pincheng Wang