From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10224 Path: news.gmane.org!not-for-mail From: "Zhao, Weiming" Newsgroups: gmane.linux.lib.musl.general Subject: Fix warnings when build with clang Date: Fri, 24 Jun 2016 17:18:23 -0700 Message-ID: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FB76ABEAC95630412A23F2C8" X-Trace: ger.gmane.org 1466813924 24483 80.91.229.3 (25 Jun 2016 00:18:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2016 00:18:44 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10237-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jun 25 02:18:43 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bGbJ5-0002X0-AM for gllmg-musl@m.gmane.org; Sat, 25 Jun 2016 02:18:43 +0200 Original-Received: (qmail 7279 invoked by uid 550); 25 Jun 2016 00:18:41 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7238 invoked from network); 25 Jun 2016 00:18:36 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 Xref: news.gmane.org gmane.linux.lib.musl.general:10224 Archived-At: This is a multi-part message in MIME format. --------------FB76ABEAC95630412A23F2C8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Clang gives warnings about the missing parentheses for bitwise ops. It's not functional but just code readability. musl-m3/include/endian.h:32:25: warning: '&' within '|' [-Wbitwise-op-parentheses] return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24; ~ ~~~~~~^~~~~~~ musl-m3/include/endian.h:37:23: warning: operator '<<' has lower precedence than '+'; '+' will be evaluated first [-Wshift-op-parentheses] return __bswap32(__x)+0ULL<<32 | __bswap32(__x>>32); ~~~~~~~~~~~~~~^~~~~~~ Thanks, Weiming -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation --------------FB76ABEAC95630412A23F2C8 Content-Type: text/plain; charset=UTF-8; name="musl.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="musl.patch" ZGlmZiAtLWdpdCBhL2luY2x1ZGUvZW5kaWFuLmggYi9pbmNsdWRlL2VuZGlhbi5oCmluZGV4 IDFiZDQ0NDUuLjg4YzMzNDcgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUvZW5kaWFuLmgKKysrIGIv aW5jbHVkZS9lbmRpYW4uaApAQCAtMjksMTIgKzI5LDEyIEBAIHN0YXRpYyBfX2lubGluZSB1 aW50MTZfdCBfX2Jzd2FwMTYodWludDE2X3QgX194KQogCiBzdGF0aWMgX19pbmxpbmUgdWlu dDMyX3QgX19ic3dhcDMyKHVpbnQzMl90IF9feCkKIHsKLQlyZXR1cm4gX194Pj4yNCB8IF9f eD4+OCYweGZmMDAgfCBfX3g8PDgmMHhmZjAwMDAgfCBfX3g8PDI0OworCXJldHVybiBfX3g+ PjI0IHwgKF9feD4+OCYweGZmMDApIHwgKF9feDw8OCYweGZmMDAwMCkgfCBfX3g8PDI0Owog fQogCiBzdGF0aWMgX19pbmxpbmUgdWludDY0X3QgX19ic3dhcDY0KHVpbnQ2NF90IF9feCkK IHsKLQlyZXR1cm4gX19ic3dhcDMyKF9feCkrMFVMTDw8MzIgfCBfX2Jzd2FwMzIoX194Pj4z Mik7CisJcmV0dXJuIChfX2Jzd2FwMzIoX194KSswVUxMKTw8MzIgfCBfX2Jzd2FwMzIoX194 Pj4zMik7CiB9CiAKICNpZiBfX0JZVEVfT1JERVIgPT0gX19MSVRUTEVfRU5ESUFOCg== --------------FB76ABEAC95630412A23F2C8--