From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3972 invoked from network); 3 Aug 2022 14:42:16 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 3 Aug 2022 14:42:16 -0000 Received: (qmail 13595 invoked by uid 550); 3 Aug 2022 14:42:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 13561 invoked from network); 3 Aug 2022 14:42:12 -0000 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JoV3sLwsXA85dMEWfrxdnYmQdEeuFQxJribMl5/c49Vv9tUezFaiuGeaMDgStjVM1oZ1m/IAtdvciCA0vInG4IUheRpZ8GHD9P8dJvhPJLrOYZegT+ZQ2MOIpTHecSdZ6JGjfULFk8yhkbrT2SAjdFwbmEEEc1OtsddXT6msp5aPvTQFGhGeIbqPPOKUPl2oWpEHCUw0zHG0/QwUt7y8fsi9TMaFGf4JZ++n/8YzjlMBeONJ45UynyU0wG3pGaSxaoa/LQ9clFy6OHq2PUftC+KYy/EOi7S1/diiXN2gaxajUY/MOIwCXoMuYQl7H4tydDBMs6udtP2j2ZyDDIpyAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2+0/A1rZQfx4qERJujvrYTbhSaFA5NIHoLAWeq8i6w=; b=jsi4dgPaj4YgPAtAzAWLpiV5ZFlFUFVJeES4ntXWK5qjwQooFgToHaS8WJ12EPreFKiOjFSan0FFzuOwhsBRnglM7hKY9nXXw8eciHu14+kKQzvCX//SetOCfH6hTDzqkVWESs5i2Dsu8HlF/MSPiIha+3r6z11ksow5jdWB12buZbmcEI44/dj2obbR19wFHFadyPvV7Ybb331hCpDo8//JBxrs7q4dedPleTuCOrBUj/76V2pY21Uzg/p8yJbTadZ9dvRxDhOhn3XsqvEGj8uInT8qpWh81Wgmsr++Ny6PQBQMSYS/8q6yuA4J9wnvyGEZRQHZeyXSbtDaD0ajtA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.openwall.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2+0/A1rZQfx4qERJujvrYTbhSaFA5NIHoLAWeq8i6w=; b=sEYqAtEveZKCMdeVf3yF2jgKo5pa5vcnAoJPPoevqsTml1rNKYqoRqxcsoF5+moUy6r+GdNhyiW1YKM0SjeO133PbbYZ49/R8naR5bTCVpt5hOTgoZGMayv0P5kqMLOubd/N4zNgBGf/LkS9T1o+YQJ52fVvWE2eRlViJyxHbZo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e5bdc23701076014 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NyphCpsbQt8QGeWYPMhRZbNohdsuyaherMeNqFDfROSipHmiE1SGE0lume+Kt8XtrXM+COLCcBbBuWCNqIkC51QdYeyB6fmImylWFjf1i/LUI5uZKghxzzrDjBalmxZen0gR2IRZQik8Tg+JDeqXago9skXZYLMy6D9S74gowxDkxVxY/HXGODaR5hEhwrW0zWPg+IEivapJZL5iZFWC1XQGoGJNoDT0dJjFE6eSMglYAC5eYPSzWi+97YSo/6KruRpD83rtI87IDwDCVdHhdYwJi3mQEbTFzFUeKxOBbHhFHlyt8mVZCmIBMYfZaLvnaBWMbTqjv1SOfM2WIoLprA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2+0/A1rZQfx4qERJujvrYTbhSaFA5NIHoLAWeq8i6w=; b=cVKUIehvqRm8gMLs7Gsex5I+7rGWBc7m59AMYEyPwnQc7mitSB3DAVfE7lfjjVCPvxR2JKz5R6Jcx8QBtbLRTRgoFN3HXRGyd9oQh/PIRKo3Ko3aDqzPmZy7Jf+9QLlODU0CfsH+pwKmhjFHY+2IfZGWi7ah9zCMZcxpQK9KrOTEjFnwFQsOgyElnXZi+YZmlSlhMGsxMYySTAhL9a+/7UurWAuRXeaZW65Vv0pK8RVz1cr2bEy0axR4DAiNR9xwEaWY7T+f7EtxChyZL6ORfIPUe+t5TUJ3bYH50DTlobgs4PqFnlSCdmwvQWS4ks4HwAtuUoBa6St9TuEgeKGqrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2+0/A1rZQfx4qERJujvrYTbhSaFA5NIHoLAWeq8i6w=; b=sEYqAtEveZKCMdeVf3yF2jgKo5pa5vcnAoJPPoevqsTml1rNKYqoRqxcsoF5+moUy6r+GdNhyiW1YKM0SjeO133PbbYZ49/R8naR5bTCVpt5hOTgoZGMayv0P5kqMLOubd/N4zNgBGf/LkS9T1o+YQJ52fVvWE2eRlViJyxHbZo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Wed, 3 Aug 2022 15:42:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Rich Felker Cc: musl@lists.openwall.com References: <20220802113036.302819-1-tudor.cretu@arm.com> <20220802185346.GS7074@brightrain.aerifal.cx> From: Tudor Cretu In-Reply-To: <20220802185346.GS7074@brightrain.aerifal.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9P221CA0024.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::29) To DB7PR08MB3276.eurprd08.prod.outlook.com (2603:10a6:5:21::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7bb02d71-c214-4336-f43f-08da755e524b X-MS-TrafficTypeDiagnostic: AM6PR08MB3752:EE_|VE1EUR03FT043:EE_|AM7PR08MB5304:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n2fTGaP+5tdwox0yyQuUm0zJdXXMwqaKWXXYy8iGjszb+rHhtnL7PjmOYWKgyWipoOUM10y/g+c4A6tzV5q7rpDJwnpHhT+A4V8B733wgDQz0d+TgE9B8fvzcWZGQ/mp/gNQihlVTQvl/FxOIF2hIekE6EVNnLAQqXYnZ7THOFBvWDPJSNL/8caEN331B0gTLEen+cNCntrYGC50F4Ab7lZvbeqSaLIaG/sIk1Nany+vZRUUiS4Ji6+FEiikMFDv5nG8F4cS2775GCYL1MTi6Yaap8q7Wwn1tvO0OB0SdDxYfoMTmiPjw3DO2bLmC4EIDu86/bGXssw38fm7VuykSd0+KpDsrEA/7FqjsLifu9dGxpV47htOOqLI7bAKP7YSWpAIxMYa2qeJP4CN/GQ+eiQVgDgQs843b8nwpFE7CLZkgI4sHr5YzvCO+YH4bjr6G9JiXu80w4w0Nhz6MRcBeKi50kZshW69l0PqHfqJBE5XOD/yKIAgn9ZMBVEisycMGcfnhklNn6GNcWkvPYF90vaAYynkajKH1uGbNQeyLmtlx+7+xPTYS42HQmg9QTgE8MZjFQuUha2RE3gT0OD9Y6lQJBxKzrPj+ThXHtMXmoMIWL6j26OG3pJ6jLPQcn0JqgwnH+12dDbzgwiHLkuNqyAZ8efXROMrjpvWOC8rtHUmdWnWvNH/FzhcBcQ6QtL6x1FHADJ6Uhx9ltbNmtQS6Y3iCtdg+BT3FtwG5MueQC5Sv/ThoY9DBg1bbXgeWQwULSrXbW3tqiynFVq7kOCkbR+iincekE2hX1o12dZxGHuOKU6SPEVllkf/QXX/MKN2r8epR9M1Q0hiPR+MRzfATQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3276.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(346002)(39860400002)(136003)(376002)(31696002)(26005)(86362001)(41300700001)(6506007)(6512007)(53546011)(316002)(478600001)(6486002)(6916009)(38100700002)(2616005)(44832011)(83380400001)(186003)(2906002)(66946007)(4326008)(36756003)(8936002)(66476007)(31686004)(5660300002)(8676002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3752 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c4ac104e-09ee-41d4-7a2f-08da755e4c13 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D61Z4PsvMym6550+HJqaOUtUPk/x1rfn2YdcOvkzSl4/43hwdEBJuxCUAMxx2EVwMEd2Mqwy5hq05QpAaYuLQB+jHbNOKPXvL9OCKLgpwL/PNhI8xaODiS5UQ+5B9oXXKGWyxzQpKveyG6dPQwQE6ZcJgwQpnw35lfI77wgcqB3srTLspSuxAbh2GNflaqh959guOD05Fh0VBu7UTJGwLDuIwBXsubW8+RgV86+8Xqhjw1SM2oJnyL/0Qed9BKLE7xRZmC62QE94jFaEALS2fuRpHzBng8hkqFVnkzggXIYgMCUwdPNZYClC41rfNlJQwB+3f7XcoWUojbLvhc3iQFjLjWwStQQ2NheKOkIJN4IlNuPF6dj7OzShT8J2F09vy5Occg4lo2/TKtYk+q8Q7N08eS1jTpmwdHr0DsLm1cpLOebUBi0y/5qXFm85lzmpAOOubFy73UrfsMtAJNuqgLoONjK0YVV4B7gNV6R0NUPo1PtOxpprJHjjbjLO8ZzQc0hvxcHz3+Ggw9bS680zKUjh8jWDJdN1yg1Dp50H6f5Pe1LHsqx4cjjG25uuZtS8obElyY+4EHoQPXyraDtQFNVqCoJVhxsrBSVzBpLmKGND1eEuq4whkzlplDQtAeVo1weMNd8Y1C1wHXkvsqdByFX4lSoNfpDhD4Zzk75RFEqi39twzBQ7QPpuNyvqYp1TQQyXfRBegHb34+Ek9CpTlBYRbxnl6I7yDnKL+UjLOOuCBpmSzrv/ostSEcrv1/JxW9cb6EuLszD9q2VqR0lCr6WaRWQghmg1t+G5YoGZWvVURE4k4Wsvzsb6lAWlEUyoAcASFPEVd3IXOMaGwJKD8w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(39860400002)(376002)(40470700004)(46966006)(36840700001)(26005)(53546011)(478600001)(86362001)(82740400003)(6512007)(356005)(6862004)(6486002)(6506007)(41300700001)(82310400005)(5660300002)(2906002)(44832011)(8936002)(40480700001)(31696002)(81166007)(83380400001)(2616005)(186003)(40460700003)(47076005)(336012)(316002)(31686004)(4326008)(70586007)(8676002)(70206006)(36756003)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 14:41:59.3181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb02d71-c214-4336-f43f-08da755e524b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5304 Subject: Re: [musl] [PATCH] clone: Return EINVAL for null stack On 02-08-2022 19:53, Rich Felker wrote: > On Tue, Aug 02, 2022 at 12:30:36PM +0100, Tudor Cretu wrote: >> This change aligns the clone wrapper with the man page. If the stack is >> null, clone sets errno to EINVAL, instead of throwing a segmentation fault. >> --- >> src/linux/clone.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/src/linux/clone.c b/src/linux/clone.c >> index 8c1af7d3..43a6803b 100644 >> --- a/src/linux/clone.c >> +++ b/src/linux/clone.c >> @@ -1,4 +1,5 @@ >> #define _GNU_SOURCE >> +#include >> #include >> #include >> #include >> @@ -11,6 +12,10 @@ int clone(int (*func)(void *), void *stack, int flags, void *arg, ...) >> pid_t *ptid, *ctid; >> void *tls; >> >> + if (!stack) { >> + return __syscall_ret(-EINVAL); >> + } >> + >> va_start(ap, arg); >> ptid = va_arg(ap, pid_t *); >> tls = va_arg(ap, void *); >> -- >> 2.25.1 > > This is probably okay, but there's also a bigger discussion to be had > here about what to do about clone() -- deciding what the contract is > for what usage can be supported, and possibly making the rest produce > errors like the above. There's also a matter of the current very-wrong > use of va_arg for variadic arguments that might not exist, and which > probably *can't* exist in any valid application usage. This came up > before as part of the mt-fork work, but was basically deferred > indefinitely... > > Rich Hi Rich, Thank you for your reply. This is definitely a discussion to be had and I appreciate you sharing your thoughts. Just wanted to point out that the missing EINVAL issue popped up while running the LTP tests for clone. So, maybe this small change is still worth adding before having the bigger discussion. Thanks, Tudor