答复: [musl] [PATCH] ftello: Need adjust file offset before switching to write

["wangjianjian (C)" <wangjianjian3@huawei.com>]

I don't think this has something to do with ungetc or UB.
If don't call ungetc and replace fputs with others, like fwrite or fputc, the result of ftell or final file content is not correct.

-----邮件原件-----
发件人: Rich Felker [mailto:dalias@aerifal.cx] 代表 Rich Felker
发送时间: 2019年12月18日 21:47
收件人: wangjianjian (C) <wangjianjian3@huawei.com>
抄送: musl@lists.openwall.com; Songyunlong (Euler) <yunlong.song@huawei.com>
主题: Re: [musl] [PATCH] ftello: Need adjust file offset before switching to write

On Wed, Dec 18, 2019 at 10:18:16AM +0000, wangjianjian (C) wrote:
> Consider below code flow:
> 
> FILE *fp = fopen("foobar", "w+");
> fputs("hello", fp);
> rewind(fp);
> fgetc(fp);
> ungetc('x', fp);
> fputs("world", fp);
  ^^^^^^^^^^^^^^^^^^^

This line produces UB. You can't perform a write after ungetc without an intervening successful seek (or hitting EOF).

Rich