From: Florian Fainelli <f.fainelli@gmail.com>
To: musl@lists.openwall.com, Hauke Mehrtens <hauke@hauke-m.de>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Carlos O'Donell <carlos@redhat.com>,
Felix Janda <felix.janda@posteo.de>
Subject: Re: Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs
Date: Mon, 9 Oct 2017 20:30:12 -0700 [thread overview]
Message-ID: <c5d7dedd-4f67-7fd6-bb49-b369803f9f4d@gmail.com> (raw)
In-Reply-To: <6896b985-151e-1dd9-ec91-7ce1300cc45b@hauke-m.de>
Le 10/01/17 à 03:37, Hauke Mehrtens a écrit :
> On 07/29/2017 04:02 PM, Felix Janda wrote:
>> libc-compat.h aims to prevent symbol collisions between uapi and libc
>> headers for each supported libc. This requires continuous coordination
>> between them.
>>
>> The goal of this commit is to improve the situation for libcs (such as
>> musl) which are not yet supported and/or do not wish to be explicitly
>> supported, while not affecting supported libcs. More precisely, with
>> this commit, unsupported libcs can request the suppression of any
>> specific uapi definition by defining the correspondings _UAPI_DEF_*
>> macro as 0. This can fix symbol collisions for them, as long as the
>> libc headers are included before the uapi headers. Inclusion in the
>> other order is outside the scope of this commit.
>>
>> All infrastructure in order to enable this fallback for unsupported
>> libcs is already in place, except that libc-compat.h unconditionally
>> defines all _UAPI_DEF_* macros to 1 for all unsupported libcs so that
>> any previous definitions are ignored. In order to fix this, this commit
>> merely makes these definitions conditional.
>>
>> This commit together with the musl libc commit
>>
>> http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258
>>
>> fixes for example the following compiler errors when <linux/in6.h> is
>> included after musl's <netinet/in.h>:
>>
>> ./linux/in6.h:32:8: error: redefinition of 'struct in6_addr'
>> ./linux/in6.h:49:8: error: redefinition of 'struct sockaddr_in6'
>> ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq'
>>
>> Signed-off-by: Felix Janda <felix.janda@posteo.de>
>> ---
>> v3: Fix typos, add a comment to the file and use #ifndef.
>> v2: The only change to the previous version is the commit title and
>> message.
>
> Was this send to the wrong mailing lists? I would like to see this in
> the mainline kernel and I am wondering why it neither gets any comments
> nor shows up in linux-next.
Same here. Without such changes we cannot essentially build upstream
kernels in OpenWrt/LEDE using musl-libc without patching kernel headers,
which is really not great...
--
Florian
prev parent reply other threads:[~2017-10-10 3:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 14:02 Felix Janda
2017-08-26 20:31 ` Hauke Mehrtens
2017-10-01 10:37 ` Hauke Mehrtens
2017-10-10 3:30 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5d7dedd-4f67-7fd6-bb49-b369803f9f4d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=carlos@redhat.com \
--cc=davem@davemloft.net \
--cc=felix.janda@posteo.de \
--cc=hauke@hauke-m.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).