From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13800 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "A. Wilcox" Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] eliminate strict parentheses warnings for byteswaps Date: Thu, 14 Feb 2019 19:55:50 -0600 Organization: =?UTF-8?Q?Ad=c3=a9lie_Linux?= Message-ID: References: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Udbh8G6X6VA866LQsyqqyzRKfqDs2Rsso" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9549"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: musl@lists.openwall.com Original-X-From: musl-return-13816-gllmg-musl=m.gmane.org@lists.openwall.com Fri Feb 15 02:55:29 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1guSiu-0002NT-HP for gllmg-musl@m.gmane.org; Fri, 15 Feb 2019 02:55:28 +0100 Original-Received: (qmail 28111 invoked by uid 550); 15 Feb 2019 01:55:25 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 28091 invoked from network); 15 Feb 2019 01:55:25 -0000 Openpgp: preference=signencrypt In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:13800 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Udbh8G6X6VA866LQsyqqyzRKfqDs2Rsso Content-Type: multipart/mixed; boundary="fauS5n1YiaQLp0YK4bbosiKQkMkX5gaD6"; protected-headers="v1" From: "A. Wilcox" To: musl@lists.openwall.com Message-ID: Subject: Re: [musl] [PATCH] eliminate strict parentheses warnings for byteswaps References: In-Reply-To: --fauS5n1YiaQLp0YK4bbosiKQkMkX5gaD6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 02/14/19 18:24, Nick Bray wrote: > Patch is attached. >=20 > The change was motivated by including Musl's headers from a project > with -Werror -Wall enabled. I believe Fucshia ran into this, too. I > couldn't think of a good regression test, in part because warnings are > somewhat compiler specific. One possible approach would be to enable > -Werror -Wall in the main build, but that runs into issues of which > compilers are supported and what the core developers prefer. Another > approach would be to only lint the header files - generate a dummy .c > file that includes all the header files and compile it with -Werror. > This is complicated by the "redirection" header files that warn you > should use the canonical version. Which header files should be > checked? So for the moment I punted on regression testing. I mention > this line of thinking in case anyone has some perspective.=20 This has a strong +1 from me, but changes like this have already been rejected at least twice on this list because "compilers shouldn't warn about system headers". Perhaps at attempt #3, they will just accept that this happens regularly enough that a few parens is not the end of the world. (It also makes more components of musl reusable in other libraries, if desired.) Best, --arw --=20 A. Wilcox (awilfox) Project Lead, Ad=C3=A9lie Linux https://www.adelielinux.org --fauS5n1YiaQLp0YK4bbosiKQkMkX5gaD6-- --Udbh8G6X6VA866LQsyqqyzRKfqDs2Rsso Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjNyWOYPU1SaTSMHHyynLUZIrnRQFAlxmHCYACgkQyynLUZIr nRT6Kw/+NSus//RzocvykXi9QCQaZazWVcQHYpeqbm3gt+vkkTI53L7VIpP9Lumb UNQ2+BcmwOyCMLoS9/Jp4J3za4m45zWWBjYEeVacujzBUuv2/BI3i2K3XcLNsjwL gfVKgzfjomf3sX17Kx3AhGBuDLuwfQrFYcnnsYtrumOPbhCXvP9pspsVhEnGxOIX uc1ochCqDbIaDzMinYV360ZqEftVdmBidVILlgQllOEiT1S2P7gaNVVqiBoBZJiv 5On+IASzPlroeEsX4GAB3Zrjtz9YqE38uKpMjFR6buGLy1qwkoTC+63Qg2j9weqy JCrywoFxl2teVLuhuU3f8YSdMNyx5+m1P8DouUW0vL/ms36RCao60v6B8s2UMFfY bJLwS6Uq3sVt5ay+Z16EHKn2HEhdQUeL4o8MGVFNw8O5OBhSyGmEuPFZJa6vdCzl ENXd4ojBXdzZQMkNFq/cPWsAttnaTPFMDCcz/PGskexAeeLl7jL3hTXcpOb7fQ2a Qzm2zUKszc8XYdtbY4winxSd2AneRFsa0P2tjP+H5ynh5WKLkVTDcOgJ52HDgH7g r4eLxu4xehK/ashnRPE9Lc6vEX7x2armm+8uuohzKHPICKfhe7OXLFfdLl4Pu4g6 H0PusF9CG/Qz1tgPhHXUUnC4rKcQFo/+QhPpmpbvqoiigbVl1FA= =gY0Y -----END PGP SIGNATURE----- --Udbh8G6X6VA866LQsyqqyzRKfqDs2Rsso--