From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id D567E2BE4D for ; Thu, 15 Aug 2024 04:12:53 +0200 (CEST) Received: (qmail 7865 invoked by uid 550); 15 Aug 2024 02:12:48 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 7824 invoked from network); 15 Aug 2024 02:12:47 -0000 Date: Thu, 15 Aug 2024 12:12:35 +1000 (AEST) From: Damian McGuckin To: MUSL In-Reply-To: <20240815011655.GN10433@brightrain.aerifal.cx> Message-ID: References: <21ca5c9-b1e-71b5-87b-a37f81f691ab@esi.com.au> <20240811200812.GZ3766212@port70.net> <7e9463-98a3-4b2-c10-e3fbf79a6b8@esi.com.au> <5918d2a7-7b3-932b-2b4-b24390832244@esi.com.au> <20240812090022.GA3766212@port70.net> <20240815011655.GN10433@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Subject: Re: [musl] catan(z) On Wed, 14 Aug 2024, Rich Felker wrote: > If I'm following, it sounds like the current behavior is either a > no-op or wrong and removing the _redupi step entirely would make it > correct or at least closer to correct. Do you agree? Just a no-op. Unless there is some subtle reason why Moshier did this why I am too dumb to understand. I think the issue was that back in the 80s when he wrote it, there were some unstandardised atan2() routines which (Moshier alluded to in his book and which) returned results in [0,2*pi] rather than the now standardized routines with return in [-pi,+pi] and he was handling those issues. > Any suggestions for a test to run? I did some basic smoke testing for > large positive real inputs and got expected results. Not off hand. Other issues taking my brain cycles right nnow. Young Mr Nagy might have a better idea. Thanks - Damian