From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9813 Path: news.gmane.org!not-for-mail From: Sebastian Gottschall Newsgroups: gmane.linux.lib.musl.general Subject: Re: recvmsg/sendmsg broken on mips64 Date: Fri, 1 Apr 2016 13:37:05 +0200 Message-ID: References: <20160331192518.GW21636@brightrain.aerifal.cx> <20160331201012.GR9862@port70.net> <20160331203004.GX21636@brightrain.aerifal.cx> <76c20e67-4d62-a929-9f1d-a3fc63758426@dd-wrt.com> <20160401094919.GT9862@port70.net> <02844173-9671-d0e9-a291-764b27899f44@dd-wrt.com> <20160401113146.GU9862@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1459510608 11123 80.91.229.3 (1 Apr 2016 11:36:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Apr 2016 11:36:48 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9826-gllmg-musl=m.gmane.org@lists.openwall.com Fri Apr 01 13:36:43 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1alxNb-00015w-9v for gllmg-musl@m.gmane.org; Fri, 01 Apr 2016 13:36:43 +0200 Original-Received: (qmail 21593 invoked by uid 550); 1 Apr 2016 11:36:41 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 20466 invoked from network); 1 Apr 2016 11:36:24 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To; bh=P0YrjpDF8xQrI3tzF9Y9NnBAh9KVi1cC1V96AKzoT5U=; b=l7KNRLHZ+Gtpxp/e2/i5uWZtixdrZQPvN9shsEYH1jXdIHADqkPpDGZrVBuR0IjQlriyELx66i7cZmLr2ihk+Oce92s2mGCS0twTzUmR+Gnep+wzW3Oz9uhKLZP7wUJDw+hFvQxF+e001eOQCBVJ1PiqGwN6/QktUpKjEntBnQo=; User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <20160401113146.GU9862@port70.net> X-SA-Exim-Connect-IP: 93.195.6.161 X-SA-Exim-Mail-From: s.gottschall@dd-wrt.com X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on webmail.newmedia-net.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=4.0 tests=ALL_TRUSTED,BAYES_00, DNS_FROM_AHBL_RHSBL,RATWARE_GECKO_BUILD autolearn=no version=3.1.9, No X-SA-Exim-Version: 4.2.1 (built Thu, 26 May 2011 15:22:33 +0200) X-SA-Exim-Scanned: Yes (on webmail.newmedia-net.de) X-NMN-MailScanner-Information: Please contact the ISP for more information X-NMN-MailScanner-ID: 1alxN6-0000CG-BX X-NMN-MailScanner: Found to be clean X-NMN-MailScanner-From: s.gottschall@dd-wrt.com X-Received: from [93.195.6.161] (helo=[172.29.0.169]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1alxN6-0000CG-BX for musl@lists.openwall.com; Fri, 01 Apr 2016 13:36:12 +0200 Xref: news.gmane.org gmane.linux.lib.musl.general:9813 Archived-At: Am 01.04.2016 um 13:31 schrieb Szabolcs Nagy: > * Sebastian Gottschall [2016-04-01 12:29:35 +0200]: > >> Am 01.04.2016 um 11:49 schrieb Szabolcs Nagy: >>> * Sebastian Gottschall [2016-04-01 11:16:20 +0200]: >>>> I discovered that the whole recvmsg/sendmsg code is broken in mips64 >>>> but i found also the solution >>>> i throwed out all the _pad1, _pad2 crap in socket.h and the corrosponding >>>> code in recvmsg.c etc. >>>> and used size_t instead. this works at the end. i see no reason for this >>>> padding, since using the correct datatype will handle it in the same way. >>>> this solution may also work for other 64 bit targets. so proposal is fixing >>>> the datatype instead of using int with padding in case of 64 bit >>>> >>> the padding is needed, i think __BIG_ENDIAN >>> or __LITTLE_ENDIAN might not be defined properly. >> i checked this already. it was defined properly. the only solution was using >> the correct datatypes as defined in the kernel and i also checked uclibc. it >> uses also just size_t and nothing else. >> the padding results in the same datatype size, just clears the upper and >> lower word. but this doesnt seem to be neccessary >>> your fix is non-conforming and breaks both abi and api, >>> the definition must match >> socklen_t would result in the same 64bit datatype instead of int + pad >> (which is 64 bit too). so its conforming. >> i mached by header variant by reading the kernel headers which uses size_t >> instead of socketlen_t >> so i assume socketlen_t maches size_t > msg_iovlen must be int > msg_controllen and cmsg_len must be socklen_t the kernel uses size_t > > the socklen_t typedef must match what the size > the socket syscalls expect which is int. > > uclibc and linux uapi is known to be broken, > linux uapi is not fixed because of abi compat > but we can work this around in musl. > > if the endian macros are defined then the padding > should work. okay. but musl is a library used with linux only. so if linux uses size_t, then musl must use the same abi. otherwise musl wont work with unimportant programs like "ip" for 64 bit targets (havent checked x64 yet) >>> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html >>> >>>> this here is my working struct in mips64 (big endian) >>>> >>>> struct msghdr { >>>> void *msg_name; >>>> socklen_t msg_namelen; >>>> struct iovec *msg_iov; >>>> size_t msg_iovlen; >>>> void *msg_control; >>>> size_t msg_controllen; >>>> int msg_flags; >>>> }; >>>> >>>> struct cmsghdr { >>>> size_t cmsg_len; >>>> int cmsg_level; >>>> int cmsg_type; >>>> }; >>>> >>>> >>>> Sebastian