mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Arvid E. Picciani" <aep@exys.org>
To: <musl@lists.openwall.com>
Subject: getpwent.c:  isn't line supposed to be set NULL?
Date: Mon, 13 Aug 2012 12:04:14 +0200	[thread overview]
Message-ID: <d6b36877494030239d990d659abc29c1@exys.org> (raw)

the getpw* functions call getline in a dubious way
for example:

struct passwd *__getpwent_a(FILE *f, struct passwd *pw, char **line, 
size_t *size)
[..]
		if ((l=getline(line, size, f)) < 0) {
			free(*line);
			*line = 0;


is called from

struct passwd *fgetpwent(FILE *f)
[..]
	static char *line;
	return __getpwent_a(f, &pw, &line, &size);


where line is uninitialized.

first thing getdelim (forwarded from getline) does is:

if (!*s) *n=0;

so this looks wrong somewhere.
maybe i'm just missing an =0 in between.


-- 
Arvid E. Picciani


             reply	other threads:[~2012-08-13 10:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 10:04 Arvid E. Picciani [this message]
2012-08-13 10:29 ` Ivan Kanakarakis
2012-08-13 10:30   ` Arvid E. Picciani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6b36877494030239d990d659abc29c1@exys.org \
    --to=aep@exys.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).