From: Alexey Izbyshev <izbyshev@ispras.ru>
To: musl@lists.openwall.com
Subject: Re: [musl] Why is setrlimit() considered to have per-thread effect?
Date: Thu, 15 Oct 2020 18:50:41 +0300 [thread overview]
Message-ID: <dd915908f227301a1d4cc67332257c04@ispras.ru> (raw)
In-Reply-To: <20201015085024.GR2947641@port70.net>
On 2020-10-15 11:50, Szabolcs Nagy wrote:
> note that prlimit does not have synccall in
> musl: the kernel implemented the per process
> rlimit setting when prlimit was added.
> (i think this is linux commit
> 1c1e618ddd15f69fd87ccea596769f78c8065504 )
>
> but older kernels don't have that.
>
Ah, thank you for checking that, though the transition appear to have
happened much earlier than the commit you referenced (which is not
relevant), in pre-git epoch between 2.6.9 and 2.6.10[1, 2]. I was
confused because Linux man pages never mention that and explicitly say
"Resource limits are per-process attributes that are shared by all of
the threads in a process."[3], but I should have checked old sources.
>> Tangentially, setgroups() is not called via __synccall(), though it
>> does
>> have per-thread effect. Is this intentional?
>
> that may be a bug, but it's not a posix api
> so not a conformance issue, but a linux issue:
> if other linux libcs don't do synccall then
> that's the defacto interface contract.
>
FWIW, glibc does synccall since 2011:
https://sourceware.org/git/?p=glibc.git;a=commit;h=70181fddf14
[1] https://elixir.bootlin.com/linux/v2.6.9/source/kernel/sys.c#L1537
[2] https://elixir.bootlin.com/linux/v2.6.10/source/kernel/sys.c#L1487
[3] https://man7.org/linux/man-pages/man2/setrlimit.2.html
next prev parent reply other threads:[~2020-10-15 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 5:01 Alexey Izbyshev
2020-10-15 8:50 ` Szabolcs Nagy
2020-10-15 15:49 ` Rich Felker
2020-10-15 16:13 ` Alexey Izbyshev
2020-10-15 17:13 ` Rich Felker
2020-10-15 18:26 ` Alexey Izbyshev
2020-10-15 20:03 ` Rich Felker
2020-10-15 15:50 ` Alexey Izbyshev [this message]
2020-10-15 20:05 ` Rich Felker
2020-10-15 15:43 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd915908f227301a1d4cc67332257c04@ispras.ru \
--to=izbyshev@ispras.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).