Re: [musl] [PATCH v2] MT fork

[Alexey Izbyshev <izbyshev@ispras.ru>]

On 2020-11-11 03:52, Rich Felker wrote:
> Here's a proposed first patch in series, getting rid of getdelim/stdio
> usage in ldso. I think that suffices to set the stage for adding
> __libc_malloc, __libc_free, __libc_calloc, __libc_realloc and having
> ldso use them.
> 

> +static ssize_t read_loop(int fd, void *p, size_t n)
> +{
> +    unsigned char *b = p;
> +    for (size_t l, i=0; i<n; i+=l) {
> +        l = read(fd, b+i, n-i);
> +        if (l<0) {
> +            if (errno==EINTR) continue;
This increments `i` by a negative `l`.
> +            else return -1;
> +        }
> +        if (l==0) return i;
> +    }
> +    return n;
> +}

> +                if (fd>=0) {
> +                    size_t n = 0;
> +                    if (!fstat(fd, &st)) n = st.st_size;
> +                    sys_path = malloc(n+1);
> +                    sys_path[n] = 0;
`sys_path` can be NULL here.
> +                    if (!sys_path || read_loop(fd, sys_path, n)<0) {
>                         free(sys_path);
>                         sys_path = "";
>                     }
> -                    fclose(f);
> +                    close(fd);
>                 } else if (errno != ENOENT) {
>                     sys_path = "";
>                 }

Alexey