From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14424 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "A. Wilcox" Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/5] fix warning dangling-else Date: Mon, 22 Jul 2019 13:50:07 -0500 Organization: =?UTF-8?Q?Ad=c3=a9lie_Linux?= Message-ID: References: <20190722180740.16951-1-me@concati.me> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aeUd0rDPpNpIsO9RTUGSh2EQbdstDlnLq" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46253"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: musl@lists.openwall.com Original-X-From: musl-return-14440-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jul 22 20:50:29 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hpdOH-000BuZ-J3 for gllmg-musl@m.gmane.org; Mon, 22 Jul 2019 20:50:29 +0200 Original-Received: (qmail 7254 invoked by uid 550); 22 Jul 2019 18:50:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7233 invoked from network); 22 Jul 2019 18:50:26 -0000 Openpgp: preference=signencrypt In-Reply-To: <20190722180740.16951-1-me@concati.me> Xref: news.gmane.org gmane.linux.lib.musl.general:14424 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aeUd0rDPpNpIsO9RTUGSh2EQbdstDlnLq Content-Type: multipart/mixed; boundary="8PazbYW7ruRdUh3rb1JsoZpz14kzNP2NW"; protected-headers="v1" From: "A. Wilcox" To: musl@lists.openwall.com Message-ID: Subject: Re: [musl] [PATCH 1/5] fix warning dangling-else References: <20190722180740.16951-1-me@concati.me> In-Reply-To: <20190722180740.16951-1-me@concati.me> --8PazbYW7ruRdUh3rb1JsoZpz14kzNP2NW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07/22/19 13:07, Issam Maghni wrote: > Signed-off-by: Issam Maghni > --- > src/ctype/towctrans.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/src/ctype/towctrans.c b/src/ctype/towctrans.c > index 8f681018..bd0136dd 100644 > --- a/src/ctype/towctrans.c > +++ b/src/ctype/towctrans.c > @@ -259,12 +259,14 @@ static wchar_t __towcase(wchar_t wc, int lower) > || (unsigned)wc - 0xabc0 <=3D 0xfeff-0xabc0) > return wc; > /* special case because the diff between upper/lower is too big */ > - if (lower && (unsigned)wc - 0x10a0 < 0x2e) > + if (lower && (unsigned)wc - 0x10a0 < 0x2e) { > if (wc>0x10c5 && wc !=3D 0x10c7 && wc !=3D 0x10cd) return wc; > else return wc + 0x2d00 - 0x10a0; > - if (!lower && (unsigned)wc - 0x2d00 < 0x26) > + } > + if (!lower && (unsigned)wc - 0x2d00 < 0x26) { > if (wc>0x2d25 && wc !=3D 0x2d27 && wc !=3D 0x2d2d) return wc; > else return wc + 0x10a0 - 0x2d00; > + } > if (lower && (unsigned)wc - 0x13a0 < 0x50) > return wc + 0xab70 - 0x13a0; > if (!lower && (unsigned)wc - 0xab70 < 0x50) >=20 I know none of these changes have a chance of making it in, but this one specifically *does* genuinely irk me and I *would* love to see this one actually merged to musl. --arw --=20 A. Wilcox (awilfox) Project Lead, Ad=C3=A9lie Linux https://www.adelielinux.org --8PazbYW7ruRdUh3rb1JsoZpz14kzNP2NW-- --aeUd0rDPpNpIsO9RTUGSh2EQbdstDlnLq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjNyWOYPU1SaTSMHHyynLUZIrnRQFAl02BWMACgkQyynLUZIr nRTtHBAAkTvc72cOPskY1Nj3hWKeQvlPqQ0Vr/iKwPD9z5BLjg/0pGIUQ6DVocwD 1hPdLWBQ+tteYh4tGi6rBJn328OT2Im9TWDOqexArPKhLMMzZajCABQAvWCNZsMl 2M60ZfsloqUStuU3LPtnN6YVQnK0mpr6yvggTUvBoroTsNgYjJSPlbbhN/wVaYHY AHNs0u7D2KrcW2K0PIvkduaHLFqBLZwNFR2cGdA9wvLHKwp0X7FLTz3B/D/Pe8X3 kUUZTSOC1HeFK5PmP8vaHwvXlCy46xg871VEniXAytSMw/IInHEfcoljwbEgZDE+ VYVa0AHwaboGHh0VNHZryDOBnHlYpypB+iiVcxrQpLsnIunBlsU1asN3S8ZvGDSd OQThnyIJbtklfMnY4JKyl3Uz2sEIHOrG0XO0tteE+fcpkIi827SHNZywzQhYpDBS D8hjfsXMpPO2YOVYlHOdjYJcMR6pzU9ATDekq/BMA+Om2J0zGm3WEYSL8eKFD7+n YPab2+JdZtagD7OkfAXircn7Pofv3CFVN8J+gE+r1lLa9vse7TEli90PXzS/OW8f aLRuyJssRBf61KNDSywfYjW9ifkHJ0jA31rEGxXXK7Z9tAgJrbDOmObqKzHLv0BI 0pHit3Z1HKYfLo+RlvixF6BTdLtfGibK2RFlIVRRYg6PHCH1ZR8= =R7dS -----END PGP SIGNATURE----- --aeUd0rDPpNpIsO9RTUGSh2EQbdstDlnLq--