mailing list of musl libc
 help / color / mirror / code / Atom feed
From: jvoisin <julien.voisin@dustri.org>
To: musl@lists.openwall.com
Subject: [musl] Protect pthreads' mutexes against use-after-destroy
Date: Tue, 9 Jan 2024 15:37:17 +0100	[thread overview]
Message-ID: <ec138086-c5b9-4ca2-9da5-bef8b14de27d@dustri.org> (raw)

Ohai,

as discussed on irc, Android's bionic has a check to prevent
use-after-destroy on phtread mutexes
(https://github.com/LineageOS/android_bionic/blob/e0aac7df6f58138dae903b5d456c947a3f8092ea/libc/bionic/pthread_mutex.cpp#L803),
and musl doesn't.

While odds are that this is a super-duper common bug, it would still be
nice to have this kind of protection, since it's cheap, and would
prevent/make it easy to diagnose weird states.

Is this something that should/could be implemented?

o/

             reply	other threads:[~2024-01-09 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 14:37 jvoisin [this message]
2024-01-09 19:07 ` Rich Felker
2024-01-09 23:27   ` enh
2024-01-10  1:58     ` Rich Felker
2024-01-12 16:53       ` enh
2024-01-10  1:55   ` Rich Felker
2024-01-10 21:24     ` Rich Felker
2024-01-21  3:43   ` Rich Felker
2024-01-21 12:06     ` julien.voisin
2024-01-21 17:03       ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec138086-c5b9-4ca2-9da5-bef8b14de27d@dustri.org \
    --to=julien.voisin@dustri.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).