From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5265 invoked from network); 15 May 2022 03:43:13 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 15 May 2022 03:43:13 -0000 Received: (qmail 16102 invoked by uid 550); 15 May 2022 03:43:11 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 16070 invoked from network); 15 May 2022 03:43:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6n/6ES0MSddXdU9cTFwkrfQizlhK48P8olmRQzfaV6I=; b=pJEu/oTamp0iRaiavxPV5UistJpzwj24MIbUFf8GoqEdWe/DMyqaCvUlLjJm/Iobh2 Iyz5qK98Q3XGOJFE+Y/bzgkWlrJHcx+NiRmefWQPZL5bfP5HmruHs1e2mPwaI7UY8mUW V2+ppYLfvO6CwqdRykM/BsHs6tHA5NwZVXcWjgmpDaKj7BhkUz62FrwMzvwhtHlNKsbK 8OkJSBFKNduDN+Vjwa1I4kPRG32c5VeYc2lqkjaqjBxFPPdlcYMWZormGxNrx7jbi5dX /UNh7lWvR/YfAKRoHYmwPsmq8n98m3P9nZaLhWgROCuZcg2HvLcuYv8STjn6JCL25oOe 9PSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6n/6ES0MSddXdU9cTFwkrfQizlhK48P8olmRQzfaV6I=; b=YHpdUmzRvUAEek2dM9XOsb6Sc/dci77Ne8veLQA77ptq8U+s+2xtU3/GVvgjaHF8S1 eqhBcealnNOC5CmSR1BVPVmFoSDLrlewKRdZaDc+SzeXIxE93z1fG0fTTOPTAIKjtPNb lEknfe/N8KNvVReevKQxrh4fTjm9deJiPAzzf5VNoeD/YZQr8412+hf/43JpqDL48oR5 rY9oYMZJeIvNxO4ppHANKJDQ4GLYaZDY8YMKCwaj26izE7w6MPoJFtOxmzW9Ypcp/kt8 rwIENm0oLEePX9DD5XId37LwgXV4BWe0wozom2Ui1QPpgdMqU4vCgPBHnJ6PONd8rNsr 9EPQ== X-Gm-Message-State: AOAM5333aCnAsMFn970kyuPvBSTes7pGvYxE+Ru3FbcjdUG/R+m2BA0m 4VioSJ5lgf0G7Udh53qUF7c= X-Google-Smtp-Source: ABdhPJxyXUAQFqZJmzvL5V/wBKpYe5ABBHGWzBzH0n1I1sEWi9vTUZx7y5uirB3OB4GySugrasKOQQ== X-Received: by 2002:a17:90b:174a:b0:1df:3dc5:a386 with SMTP id jf10-20020a17090b174a00b001df3dc5a386mr1169771pjb.192.1652586178468; Sat, 14 May 2022 20:42:58 -0700 (PDT) Message-ID: Date: Sat, 14 May 2022 20:42:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Stafford Horne Cc: buildroot@buildroot.org, Thomas Petazzoni , mmayer@broadcom.com, yann.morin.1998@free.fr, musl@lists.openwall.com References: <20220511001947.2112747-1-f.fainelli@gmail.com> <14506c30-bf1c-71b3-bda5-b9105adf85b4@gmail.com> From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [musl] Re: [Buildroot] [PATCH] package/cpulimit: Disable build on OpenRISC with musl-libc On 5/14/2022 8:25 PM, Stafford Horne wrote: > On Sat, May 14, 2022 at 07:14:21PM -0700, Florian Fainelli wrote: >> >> >> On 5/14/2022 7:09 PM, Stafford Horne wrote: >>> On Tue, May 10, 2022 at 05:19:47PM -0700, Florian Fainelli wrote: >>>> As reported in the following autobuild report: >>>> >>>> http://autobuild.buildroot.net/results/2a9cf20949beac46d1c689df2c5b7ab0d59c08b5/ >>>> >>>> cpulimit does not build due to a lack of definition for elf_gregset_t >>>> which is not currently provided in the or1k musl-libc port. While this >>>> is being worked on, disable the build for or1k and musl-libc. >>> >>> Hello, >>> >>> You mention this is being worked on. I am curious who is working on this? >>> >>> I try to look over OpenRISC stuff, do you need me to do anything on musl for >>> this? >> >> I posted this: >> >> https://www.openwall.com/lists/musl/2022/05/10/1 >> >> if you don't mind reviewing, thanks! > > No problem, I don't have the mail in my inbox, I've subscribed to musl now. > > Put some comments below based on what I had configured in glibc. > > diff --git a/arch/or1k/bits/user.h b/arch/or1k/bits/user.h > index e69de29bb2d1..3405bf771c0f 100644 > --- a/arch/or1k/bits/user.h > +++ b/arch/or1k/bits/user.h > @@ -0,0 +1,11 @@ > +struct user_regs { > + unsigned long gpr[32]; > + unsigned long pc; > + unsigned long sr; > +}; > > OK, matches glibc. > > +#define ELF_NGREG 34 > > In glibc we define this as 32. Howerver, we define elf_gregset_t as > elf_gregset_t[34]. I don't see where ELF_NGREG is really used so I am > not sure of the impact to this. I also can't remember why I set these > different in glibc. If it this is meant to be number of general purpose registers as the name suggests, then it looks like 32 would be more adequate. > > +typedef unsigned long elf_greg_t, elf_gregset_t[ELF_NGREG]; > + > +/* or32 does not have floating point support, placeholder */ > +typedef unsigned long elf_fpregset_t; > > OpenRISC uses the same registers and floating point and integer. This is defined > in glibc as: > > /* Register set for the floating-point registers. */ > typedef elf_greg_t elf_fpregset_t[32]; OK, I will send a v2 with those fixes, thanks for taking a look! -- Florian