From: Daiki Ueno <ueno-mXXj517/zsQ@public.gmane.org>
To: Rich Felker <dalias-8zAoT0mYgF4@public.gmane.org>
Cc: musl-ZwoEplunGu1jrUoiu81ncdBPR1lH4CV8@public.gmane.org,
bug-gnu-gettext-mXXj517/zsQ@public.gmane.org
Subject: Re: [musl] Re: AM_GNU_GETTEXT without referring internal symbols?
Date: Fri, 27 May 2016 17:48:54 +0900 [thread overview]
Message-ID: <m3h9dj3myx.fsf-ueno@gnu.org> (raw)
In-Reply-To: <20160526193658.GA21636-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org> (Rich Felker's message of "Thu, 26 May 2016 15:36:58 -0400")
Rich Felker <dalias-8zAoT0mYgF4@public.gmane.org> writes:
> On Thu, May 26, 2016 at 09:53:49PM +0900, Masanori Ogino wrote:
>>
>> It looks essentially good to me. You can remove the "if test
>> $gt_api_version -ge 3; then ... fi" part before where you modified too
>> if it is not used anywhere else, I guess.
I think it is still needed when AM_GNU_GETTEXT is invoked as:
AM_GNU_GETTEXT([external], [need-formatstring-macros])
> I haven't tested it but the concept looks good to me too.
Thanks both for looking at it. I have pushed it as:
http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=b67399b40bc5bf3165b09e6a095ec941d4b30a97
For the record, I have tested it on the Alpine Linux image obtained from
http://www.nongnu.org/pretest/ using a test package created with:
$ cp .../gettext.m4 gnulib/m4
$ ./gnulib/gnulib-tool --create-testdir --dir=t gettext
(I had to copy libintl.h to the VM as Alpine doesn't install it)
Regards,
--
Daiki Ueno
prev parent reply other threads:[~2016-05-27 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:56 Masanori Ogino
[not found] ` <CAA-4+jeUF8c+Kmv0UQi0akMAtc2hmi3pC_8=nBNcsfuRcjSgNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-04 2:23 ` Daiki Ueno
[not found] ` <m3h9fit8lg.fsf-ueno-mXXj517/zsQ@public.gmane.org>
2016-04-04 4:23 ` Masanori Ogino
[not found] ` <CAA-4+jcpfOXoYx1g_48M0B7punK7r2AOU7YU-V_pdQNGYcFmng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-07 2:26 ` [musl] " Daiki Ueno
2016-04-07 5:34 ` Re: [bug-gettext] " Masanori Ogino
2016-04-07 6:26 ` Rich Felker
2016-04-07 7:12 ` Masanori Ogino
2016-04-07 10:57 ` Szabolcs Nagy
2016-04-07 13:53 ` Rich Felker
[not found] ` <CAA-4+jfbUEi1bBBP7iT2_9zaxyR+XvRb00yrWsoFj7iWiN3uUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-07 5:36 ` [musl] " Masanori Ogino
2016-05-26 6:09 ` Daiki Ueno
2016-05-26 12:53 ` Re: [bug-gettext] " Masanori Ogino
2016-05-26 19:36 ` Rich Felker
[not found] ` <20160526193658.GA21636-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2016-05-27 8:48 ` Daiki Ueno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3h9dj3myx.fsf-ueno@gnu.org \
--to=ueno-mxxj517/zsq@public.gmane.org \
--cc=bug-gnu-gettext-mXXj517/zsQ@public.gmane.org \
--cc=dalias-8zAoT0mYgF4@public.gmane.org \
--cc=musl-ZwoEplunGu1jrUoiu81ncdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).