From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10065 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.comp.gnu.gettext.bugs,gmane.linux.lib.musl.general Subject: Re: [musl] Re: AM_GNU_GETTEXT without referring internal symbols? Date: Fri, 27 May 2016 17:48:54 +0900 Message-ID: References: <20160526193658.GA21636@brightrain.aerifal.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1464338965 23902 80.91.229.3 (27 May 2016 08:49:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 May 2016 08:49:25 +0000 (UTC) Cc: musl-ZwoEplunGu1jrUoiu81ncdBPR1lH4CV8@public.gmane.org, bug-gnu-gettext-mXXj517/zsQ@public.gmane.org To: Rich Felker Original-X-From: bug-gettext-bounces+gcggb-bug-gettext=m.gmane.org-mXXj517/zsQ@public.gmane.org Fri May 27 10:49:14 2016 Return-path: Envelope-to: gcggb-bug-gettext@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6DSE-0005Fd-8B for gcggb-bug-gettext@m.gmane.org; Fri, 27 May 2016 10:49:14 +0200 Original-Received: from localhost ([::1]:44679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6DSD-0004S9-Ic for gcggb-bug-gettext@m.gmane.org; Fri, 27 May 2016 04:49:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6DS8-0004Ru-51 for bug-gettext-mXXj517/zsQ@public.gmane.org; Fri, 27 May 2016 04:49:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6DS4-0002Bx-3K for bug-gettext-mXXj517/zsQ@public.gmane.org; Fri, 27 May 2016 04:49:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6DS3-0002Br-W6; Fri, 27 May 2016 04:49:04 -0400 Original-Received: from du-a.org ([219.94.251.20]:38942 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1b6DS2-0004ZS-3t; Fri, 27 May 2016 04:49:02 -0400 In-Reply-To: <20160526193658.GA21636-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org> (Rich Felker's message of "Thu, 26 May 2016 15:36:58 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: bug-gettext-mXXj517/zsQ@public.gmane.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Bug reports for GNU gettext List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gettext-bounces+gcggb-bug-gettext=m.gmane.org-mXXj517/zsQ@public.gmane.org Original-Sender: "bug-gettext" Xref: news.gmane.org gmane.comp.gnu.gettext.bugs:1226 gmane.linux.lib.musl.general:10065 Archived-At: Rich Felker writes: > On Thu, May 26, 2016 at 09:53:49PM +0900, Masanori Ogino wrote: >> >> It looks essentially good to me. You can remove the "if test >> $gt_api_version -ge 3; then ... fi" part before where you modified too >> if it is not used anywhere else, I guess. I think it is still needed when AM_GNU_GETTEXT is invoked as: AM_GNU_GETTEXT([external], [need-formatstring-macros]) > I haven't tested it but the concept looks good to me too. Thanks both for looking at it. I have pushed it as: http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=b67399b40bc5bf3165b09e6a095ec941d4b30a97 For the record, I have tested it on the Alpine Linux image obtained from http://www.nongnu.org/pretest/ using a test package created with: $ cp .../gettext.m4 gnulib/m4 $ ./gnulib/gnulib-tool --create-testdir --dir=t gettext (I had to copy libintl.h to the VM as Alpine doesn't install it) Regards, -- Daiki Ueno