[musl] The sigtimedwait function can't return EINTR

[musl] The sigtimedwait function can't return EINTR

[=?gb18030?B?s/DT8bzT?=]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 217 bytes --]

Hi,


Why not check for EINTR errors in sigwait function instead of sigtimedwait function?
In posix, the sigtimedwait function can return an EINTR error.

Can you give me a reason for this situation?


Thanks

[-- Attachment #2: Type: text/html, Size: 364 bytes --]

Re: [musl] The sigtimedwait function can't return EINTR

[Rich Felker]

On Tue, Jun 25, 2024 at 02:14:29PM +0800, 仇玉加 wrote:
> Hi,
> 
> 
> Why not check for EINTR errors in sigwait function instead of sigtimedwait function?
> In posix, the sigtimedwait function can return an EINTR error.

It's a may fail, not a shall fail, so either behavior is allowed.

> Can you give me a reason for this situation?

Commit 0a949ebdf0b9fc054ea868bd049c8f2c7aed973e documents that it was
necessary that sigwait not fail with EINTR, so the logic to retry in
EINTR had to be added either in sigwait or sigtimedwait.

Generally we don't utilize "may fail" unless there's a good reason. In
the case of sigtimedwait, I think my reasoning was that it's already
waiting for one of a set of signals, and you could just include the
signal(s) you want to be interrupted by in that set. Since the EINTR
condition is not mandatory, this is the only portable way to do it.

Rich