From: Pedro Falcato <pedro.falcato@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [musl] Proposed printf stack usage improvement
Date: Tue, 27 Aug 2024 10:23:57 +0100 [thread overview]
Message-ID: <vfxe42rfr5khx72fm2vouagjpqq7t4t2aht3o3th6uettuxx3p@e53qkkjjchys> (raw)
In-Reply-To: <20240826200958.GD10433@brightrain.aerifal.cx>
LGTM.
But maybe you should also include my __attribute__((noinline)) sugestion, to make sure
the integer printf and floating point paths get mixed by the compiler. Even if current gcc/clang don't seem
to want to do that, it's better to be safe than sorry (and I assume any LTO/PGO might change that atm).
--
Pedro
next prev parent reply other threads:[~2024-08-27 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 20:09 Rich Felker
2024-08-27 9:23 ` Pedro Falcato [this message]
2024-08-27 15:21 ` Rich Felker
2024-08-27 15:42 ` Pedro Falcato
2024-08-27 21:32 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vfxe42rfr5khx72fm2vouagjpqq7t4t2aht3o3th6uettuxx3p@e53qkkjjchys \
--to=pedro.falcato@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).