From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 497952CE00 for ; Tue, 27 Aug 2024 11:24:13 +0200 (CEST) Received: (qmail 5495 invoked by uid 550); 27 Aug 2024 09:24:09 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 5463 invoked from network); 27 Aug 2024 09:24:09 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724750640; x=1725355440; darn=lists.openwall.com; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ybzb45jrcjzSZa6hXL0bDsBqAy4w683SqECws2CvO00=; b=lQoLD+zJqTO1z6yo9oLTbWULR4r1s6Bannjuzslgtf46PL5l9X3cqUiemPTf+bdrPc eWDspEftDKoACaQy8NgXiTwSn1wXsRPWVBav4gNaU7slAKqWqy7T6YCDTv0v5BEwrmNy jvWgTWVqz1lxaWKHNaFFuXvLQ631JH6CAisVNvgjqSiurA1mFxermBmW6r7cQXwE4j4N FSecWEK0MAeMkDM6AJw3s9xp+7eknLDpQz0M8QjfpQf069WGYmVnrVdM9W38ldd17uXW JH8EZWwACAs7Pix3DFpMtskEyQb0W3bfY1Fg5O28HGXP2dbi7QdwpHlNZzu+nZgSm42i CNng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724750640; x=1725355440; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ybzb45jrcjzSZa6hXL0bDsBqAy4w683SqECws2CvO00=; b=Kj/JgQBzNtk3cK2Et7QmC4lifW9dUU9Y1Om1AbCmXkeUnj47BSkJWbzE+qfvZ2dcey YJWjB7z9sRG9Ly9fFJT8hhpvGyPAQAkG/r2LMYkZIRoYqisfSOLLlMnt8mrDDJVlIaxU 5V75cd/YzXKHkzb3XbvqUCdpM5M9fL/szeUAIUUvVkfo1cFV9WG33pce+7ZYZClCxEDT eGloELCjcRLOTgOelf7onNjIV3WV+yBSq9JEEhXpqWHrImoUpvErS6SGwr5RHtPYucTV nUEfTBoPzv0sTIE1iEQsab3CXOgDIiEjdw6CvcGUdx7i2fMy38K0xU75NgTAyYLM14M7 kKSA== X-Gm-Message-State: AOJu0Ywr6fQyPdJCgF50wmDaNWNzPIwwXvhOvkN9Mhszu14pqMGJS+cG h7ATVXMLH3Xldp5PlJkmyICFZmBK2OYJaBWKH5Fnpka4X4LQZTfy191lmQ== X-Google-Smtp-Source: AGHT+IEtRr++KwU++eAYY5mTZouko/XGWSKKyxnaZUYrtqQ0CwleWTZmjdExsiemhvMFImACCMGJYw== X-Received: by 2002:a05:600c:5487:b0:428:31c:5a52 with SMTP id 5b1f17b1804b1-42acc9f667amr105968925e9.29.1724750639643; Tue, 27 Aug 2024 02:23:59 -0700 (PDT) Date: Tue, 27 Aug 2024 10:23:57 +0100 From: Pedro Falcato To: musl@lists.openwall.com Message-ID: References: <20240826200958.GD10433@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826200958.GD10433@brightrain.aerifal.cx> Subject: Re: [musl] Proposed printf stack usage improvement LGTM. But maybe you should also include my __attribute__((noinline)) sugestion, to make sure the integer printf and floating point paths get mixed by the compiler. Even if current gcc/clang don't seem to want to do that, it's better to be safe than sorry (and I assume any LTO/PGO might change that atm). -- Pedro