* [util-jsn] incorrect handling of escapes
@ 2013-07-07 22:56 Philipp Gesang
2013-07-08 16:18 ` Hans Hagen
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Gesang @ 2013-07-07 22:56 UTC (permalink / raw)
To: ConTeXt ML
[-- Attachment #1.1.1: Type: text/plain, Size: 372 bytes --]
Hi,
the JSON parser handles backslash escapes improperly. Example:
local data = [[ { "escapes" : "(\")(\\)(\b)(\f)(\n)(\r)(\t)",
"invalid" : "\'\v" } ]]
local stuff = utilities.json.tolua (data)
inspect(stuff)
Currently it chokes on double quotes and treats the other escapes
like Lua. Fix suggestion attached.
Best regards,
Philipp
[-- Attachment #1.1.2: util-jsn.patch --]
[-- Type: text/x-diff, Size: 1594 bytes --]
--- util-jsn.lua.orig 2013-07-08 00:09:21.834400224 +0200
+++ util-jsn.lua 2013-07-08 00:54:25.889668771 +0200
@@ -15,7 +15,7 @@
-- Reminder for me: check usage in framework and extend when needed. Also document
-- it in the cld lib documentation.
-local P, V, R, S, C, Cc, Cs, Ct, Cf, Cg = lpeg.P, lpeg.V, lpeg.R, lpeg.S, lpeg.C, lpeg.Cc, lpeg.Cs, lpeg.Ct, lpeg.Cf, lpeg.Cg
+local P, V, R, S, C, Cc, Cs, Ct, Cf, Cg, Cp = lpeg.P, lpeg.V, lpeg.R, lpeg.S, lpeg.C, lpeg.Cc, lpeg.Cs, lpeg.Ct, lpeg.Cf, lpeg.Cg, lpeg.Cp
local lpegmatch = lpeg.match
local format = string.format
local utfchar = utf.char
@@ -42,7 +42,15 @@
local whitespace = lpeg.patterns.whitespace
local optionalws = whitespace^0
-local escape = C(P("\\u") / "0x" * S("09","AF","af")) / function(s) return utfchar(tonumber(s)) end
+local escape_a = C(P("\\u") / "0x" * S("09","AF","af")) / function(s) return utfchar(tonumber(s)) end
+local escape_b = P([[\]]) / "" * S([["\/]]) --> represent themselves
+local escape_c = P([[\b]]) / "\010" --> backspace
+ + P([[\f]]) / "\014" --> form feed
+ + P([[\n]]) / "\n"
+ + P([[\r]]) / "\r"
+ + P([[\t]]) / "\t"
+local invalid = P([[\]]) / "" * (Cp() * P(1) / function (pos, chr) --[[ bug_user_about_invalid_escape (chr, pos) ]] return "" end)
+local escape = escape_a + escape_b + escape_c + invalid
local jstring = dquote * Cs((escape + (1-dquote))^0) * dquote
local jtrue = P("true") * Cc(true)
local jfalse = P("false") * Cc(false)
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 485 bytes --]
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [util-jsn] incorrect handling of escapes
2013-07-07 22:56 [util-jsn] incorrect handling of escapes Philipp Gesang
@ 2013-07-08 16:18 ` Hans Hagen
2013-07-09 9:37 ` Philipp Gesang
0 siblings, 1 reply; 3+ messages in thread
From: Hans Hagen @ 2013-07-08 16:18 UTC (permalink / raw)
To: ntg-context
On 7/8/2013 12:56 AM, Philipp Gesang wrote:
> Hi,
>
> the JSON parser handles backslash escapes improperly. Example:
>
> local data = [[ { "escapes" : "(\")(\\)(\b)(\f)(\n)(\r)(\t)",
> "invalid" : "\'\v" } ]]
> local stuff = utilities.json.tolua (data)
> inspect(stuff)
>
> Currently it chokes on double quotes and treats the other escapes
> like Lua. Fix suggestion attached.
local escapes = {
-- ["\\"] = "\\", -- lua will escape these
-- ["/"] = "/", -- no need to escape this one
["b"] = "\010",
["f"] = "\014",
["n"] = "\n",
["r"] = "\r",
["t"] = "\t",
}
local escape_un = C(P("\\u") / "0x" * S("09","AF","af")) / function(s)
return utfchar(tonumber(s)) end
local escape_bs = P([[\]]) / "" * (P(1) / escapes) -- if not found then
P(1) is returned i.e. the to be escaped char
local jstring = dquote * Cs((escape_un + escape_bs + (1-dquote))^0) *
dquote
> Best regards,
> Philipp
>
>
>
> ___________________________________________________________________________________
> If your question is of interest to others as well, please add an entry to the Wiki!
>
> maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
> webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
> archive : http://foundry.supelec.fr/projects/contextrev/
> wiki : http://contextgarden.net
> ___________________________________________________________________________________
>
--
-----------------------------------------------------------------
Hans Hagen | PRAGMA ADE
Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
| www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [util-jsn] incorrect handling of escapes
2013-07-08 16:18 ` Hans Hagen
@ 2013-07-09 9:37 ` Philipp Gesang
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Gesang @ 2013-07-09 9:37 UTC (permalink / raw)
To: mailing list for ConTeXt users
[-- Attachment #1.1: Type: text/plain, Size: 1113 bytes --]
···<date: 2013-07-08, Monday>···<from: Hans Hagen>···
> On 7/8/2013 12:56 AM, Philipp Gesang wrote:
> >Hi,
> >
> >the JSON parser handles backslash escapes improperly. Example:
> >
> > local data = [[ { "escapes" : "(\")(\\)(\b)(\f)(\n)(\r)(\t)",
> > "invalid" : "\'\v" } ]]
> > local stuff = utilities.json.tolua (data)
> > inspect(stuff)
> >
> >Currently it chokes on double quotes and treats the other escapes
> >like Lua. Fix suggestion attached.
>
> local escapes = {
> -- ["\\"] = "\\", -- lua will escape these
> -- ["/"] = "/", -- no need to escape this one
> ["b"] = "\010",
> ["f"] = "\014",
> ["n"] = "\n",
> ["r"] = "\r",
> ["t"] = "\t",
> }
>
> local escape_un = C(P("\\u") / "0x" * S("09","AF","af")) /
> function(s) return utfchar(tonumber(s)) end
> local escape_bs = P([[\]]) / "" * (P(1) / escapes) -- if not found
> then P(1) is returned i.e. the to be escaped char
>
> local jstring = dquote * Cs((escape_un + escape_bs +
> (1-dquote))^0) * dquote
Fine with me!
Best,
Philipp
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 485 bytes --]
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-09 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-07 22:56 [util-jsn] incorrect handling of escapes Philipp Gesang
2013-07-08 16:18 ` Hans Hagen
2013-07-09 9:37 ` Philipp Gesang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).