* [font-otn] bug in node mode
@ 2014-03-14 6:48 Philipp Gesang
2014-03-14 11:02 ` Hans Hagen
0 siblings, 1 reply; 6+ messages in thread
From: Philipp Gesang @ 2014-03-14 6:48 UTC (permalink / raw)
To: ConTeXt ML
[-- Attachment #1.1.1: Type: text/plain, Size: 212 bytes --]
Hi Hans,
at least the Plain format breaks as soon as you define a font in
node mode:
\font \testfont = "lmroman10-regular.otf:mode=node"
\testfont foo
\bye
Patch attached.
Best regards,
Philipp
[-- Attachment #1.1.2: font-otn.lua-fix-features.patch --]
[-- Type: text/x-diff, Size: 504 bytes --]
--- font-otn.lua.orig 2014-03-14 07:42:18.494017054 +0100
+++ font-otn.lua 2014-03-14 07:42:52.937495772 +0100
@@ -2054,8 +2054,8 @@
local features = sequence.features
if features then
-- for kind, scripts in next, features do
- for i=1,#order do --
- local kind = order[i] --
+ for i=1,#features do --
+ local kind = features[i] --
local valid = enabled[kind]
if valid then
local scripts = features[kind] --
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 485 bytes --]
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [font-otn] bug in node mode
2014-03-14 6:48 [font-otn] bug in node mode Philipp Gesang
@ 2014-03-14 11:02 ` Hans Hagen
2014-03-14 17:19 ` Philipp Gesang
2014-03-24 19:40 ` Philipp Gesang
0 siblings, 2 replies; 6+ messages in thread
From: Hans Hagen @ 2014-03-14 11:02 UTC (permalink / raw)
To: ConTeXt ML
On 3/14/2014 7:48 AM, Philipp Gesang wrote:
> Hi Hans,
>
> at least the Plain format breaks as soon as you define a font in
> node mode:
>
> \font \testfont = "lmroman10-regular.otf:mode=node"
> \testfont foo
> \bye
no, it's:
local order = features.order
for i=1,#order do --
local kind = order[i] --
-----------------------------------------------------------------
Hans Hagen | PRAGMA ADE
Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
| www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [font-otn] bug in node mode
2014-03-14 11:02 ` Hans Hagen
@ 2014-03-14 17:19 ` Philipp Gesang
2014-03-24 19:40 ` Philipp Gesang
1 sibling, 0 replies; 6+ messages in thread
From: Philipp Gesang @ 2014-03-14 17:19 UTC (permalink / raw)
To: mailing list for ConTeXt users
[-- Attachment #1.1: Type: text/plain, Size: 535 bytes --]
···<date: 2014-03-14, Friday>···<from: Hans Hagen>···
> On 3/14/2014 7:48 AM, Philipp Gesang wrote:
> > Hi Hans,
> >
> > at least the Plain format breaks as soon as you define a font in
> > node mode:
> >
> > \font \testfont = "lmroman10-regular.otf:mode=node"
> > \testfont foo
> > \bye
>
> no, it's:
>
> local order = features.order
> for i=1,#order do --
> local kind = order[i] --
D’oh. I shouldn’t patch things before breakfast. Thanks!
Philipp
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 485 bytes --]
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [font-otn] bug in node mode
2014-03-14 11:02 ` Hans Hagen
2014-03-14 17:19 ` Philipp Gesang
@ 2014-03-24 19:40 ` Philipp Gesang
2014-03-25 1:16 ` Hans Hagen
1 sibling, 1 reply; 6+ messages in thread
From: Philipp Gesang @ 2014-03-24 19:40 UTC (permalink / raw)
To: mailing list for ConTeXt users
[-- Attachment #1.1: Type: text/plain, Size: 2012 bytes --]
Hi Hans,
I’m afraid I have to bother you again with this issue. Consider
this code:
\font \mainface = "file:EBGaramond12-Regular.otf:mode=node"
\mainface foo
\bye
This breaks with the latest fontloader because in font-otn
local function initialize(sequence,script,language,enabled)
local features = sequence.features
if features then
local order = features.order
for i=1,#order do --
...
the table “features” never has a field “order”; “sequence” has
one occasionally, though not always.
Best,
Philipp
···<date: 2014-03-14, Friday>···<from: Hans Hagen>···
> On 3/14/2014 7:48 AM, Philipp Gesang wrote:
> > Hi Hans,
> >
> > at least the Plain format breaks as soon as you define a font in
> > node mode:
> >
> > \font \testfont = "lmroman10-regular.otf:mode=node"
> > \testfont foo
> > \bye
>
> no, it's:
>
> local order = features.order
> for i=1,#order do --
> local kind = order[i] --
>
>
> -----------------------------------------------------------------
> Hans Hagen | PRAGMA ADE
> Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
> tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
> | www.pragma-pod.nl
> -----------------------------------------------------------------
> ___________________________________________________________________________________
> If your question is of interest to others as well, please add an entry to the Wiki!
>
> maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
> webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
> archive : http://foundry.supelec.fr/projects/contextrev/
> wiki : http://contextgarden.net
> ___________________________________________________________________________________
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 485 bytes --]
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [font-otn] bug in node mode
2014-03-24 19:40 ` Philipp Gesang
@ 2014-03-25 1:16 ` Hans Hagen
2014-03-25 6:59 ` Philipp Gesang
0 siblings, 1 reply; 6+ messages in thread
From: Hans Hagen @ 2014-03-25 1:16 UTC (permalink / raw)
To: ntg-context
On 3/24/2014 8:40 PM, Philipp Gesang wrote:
> Hi Hans,
>
> I’m afraid I have to bother you again with this issue. Consider
> this code:
>
> \font \mainface = "file:EBGaramond12-Regular.otf:mode=node"
> \mainface foo
> \bye
>
> This breaks with the latest fontloader because in font-otn
>
> local function initialize(sequence,script,language,enabled)
> local features = sequence.features
> if features then
> local order = features.order
> for i=1,#order do --
> ...
>
> the table “features” never has a field “order”; “sequence” has
> one occasionally, though not always.
should be
local function initialize(sequence,script,language,enabled)
local features = sequence.features
if features then
local order = sequence.order
if order then
for i=1,#order do
....
end
else
-- can't happen
end
end
return false
end
went unnoticed as context uses a variant
Hans
-----------------------------------------------------------------
Hans Hagen | PRAGMA ADE
Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
| www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [font-otn] bug in node mode
2014-03-25 1:16 ` Hans Hagen
@ 2014-03-25 6:59 ` Philipp Gesang
0 siblings, 0 replies; 6+ messages in thread
From: Philipp Gesang @ 2014-03-25 6:59 UTC (permalink / raw)
To: mailing list for ConTeXt users
[-- Attachment #1.1: Type: text/plain, Size: 1324 bytes --]
···<date: 2014-03-25, Tuesday>···<from: Hans Hagen>···
> On 3/24/2014 8:40 PM, Philipp Gesang wrote:
> > Hi Hans,
> >
> > I’m afraid I have to bother you again with this issue. Consider
> > this code:
> >
> > \font \mainface = "file:EBGaramond12-Regular.otf:mode=node"
> > \mainface foo
> > \bye
> >
> > This breaks with the latest fontloader because in font-otn
> >
> > local function initialize(sequence,script,language,enabled)
> > local features = sequence.features
> > if features then
> > local order = features.order
> > for i=1,#order do --
> > ...
> >
> > the table “features” never has a field “order”; “sequence” has
> > one occasionally, though not always.
>
> should be
>
> local function initialize(sequence,script,language,enabled)
> local features = sequence.features
> if features then
> local order = sequence.order
> if order then
> for i=1,#order do
> ....
> end
> else
> -- can't happen
> end
> end
> return false
> end
>
> went unnoticed as context uses a variant
This time it’s exactly as I patched it =)
Thanks for fixing,
Philipp
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 485 bytes --]
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-25 6:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-14 6:48 [font-otn] bug in node mode Philipp Gesang
2014-03-14 11:02 ` Hans Hagen
2014-03-14 17:19 ` Philipp Gesang
2014-03-24 19:40 ` Philipp Gesang
2014-03-25 1:16 ` Hans Hagen
2014-03-25 6:59 ` Philipp Gesang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).