ntg-context - mailing list for ConTeXt users
 help / color / mirror / Atom feed
From: "Marcel Fabian Krüger" <tex@2krueger.de>
To: Hans Hagen <j.hagen@xs4all.nl>
Cc: mailing list for ConTeXt users <ntg-context@ntg.nl>
Subject: Re: Variable OTF font resulting in invalid font due to stack overflow
Date: Sun, 16 May 2021 18:53:05 +0200	[thread overview]
Message-ID: <20210516165305.k24vwng5v3xulz23@beeblebrox> (raw)
In-Reply-To: <486060d2-5b24-6bfe-7ad9-445942d5976a@xs4all.nl>

On Thu, May 13, 2021 at 04:23:21PM +0200, Hans Hagen wrote:
> On 5/12/2021 11:46 PM, Marcel Fabian Krüger wrote:
> > Hi,
> > 
> > recently we got an interesting bug report in luaotfload (the original report
> > is at https://github.com/latex3/luaotfload/issues/184) which relates to the
> > ConTeXt fontloader. Take the following ConTeXt example:
> > 
> >      \starttext
> >      \definefontfeature [default:bold] [default] [axis={weight=500}]
> >      \definedfont[file:NotoSansCJKsc-VF.otf*default:bold @ 10pt]
> >      U+5E2E 帮
> >      \stoptext
> > 
> > The font is available at
> > https://github.com/googlefonts/noto-cjk/raw/main/Sans/Variable/OTF/NotoSansCJKsc-VF.otf.
> > 
> > This compiles correctly, but the CJK glyph do not appear since
> > it's Type2 CharString is invalid. The CFF2 CharStrings of this
> > glyph invokes the rrcurveto operator with 63 arguments, which is
> 
> 66 etc .. multiples of 6

Counting is hard... (I assumed that all arguments are created through
blend operators)

> 
> > allowed in CFF2 where the argument limit is 513, but not allowed in
> > Type2 where the limit is at 48.
> 
> a rather low limit right from the start (we can assume only rrcurveto is
> affected)
> 
> > It would be great if ConTeXt could check for this and insert additional
> > rrcuveto operators when necessary to avoid this issue.
> after some experiments ... attached

Thanks you very much for looking into this so quickly.

> 
> (no upload yet as i'm renaming some low level helpers which needs testing)

I've noticed that both issues are fixed in the latest upload and testing
showed that it works, except for two small issues:

  1. The cache version of the streams cache didn't change, therefore the
     fix only gets picked up if the old cache is manually deleted.
     Could it be increased to automatically trigger a rebuilt?
  2. The change to f_convert in font-ocl.lua relies on `new` being set,
     which only happens when inkscapeformat is first called which happens
     later in the same function. Therefore it does not work for the
     first SVG font loaded, while others work fine.

Best regards,
Marcel

> 
> Hans
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://context.aanhet.net
archive  : https://bitbucket.org/phg/context-mirror/commits/
wiki     : http://contextgarden.net
___________________________________________________________________________________

      reply	other threads:[~2021-05-16 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 21:46 Marcel Fabian Krüger
2021-05-13  7:19 ` Hans Hagen
2021-05-13 14:23 ` Hans Hagen
2021-05-16 16:53   ` Marcel Fabian Krüger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210516165305.k24vwng5v3xulz23@beeblebrox \
    --to=tex@2krueger.de \
    --cc=j.hagen@xs4all.nl \
    --cc=ntg-context@ntg.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).