Possible bug in core-tab?

Possible bug in core-tab?

[Aditya Mahajan]

Hi Hans,

|| does not work with tables, and until now I thought that this was a 
limitation of tables. But upon reading core-tab, it appears that you 
make a lot of effort to make sure that || works correctly, but it does 
not. I think that this is due to a mistake in the definition of 
pushouterbarandquote. Currently it is defined as

\gdef\pushouterbarandquote
   {\ifForgetTableBarAndQuote
      \let|\letterbar
      \let"\letterdoublequote
      \ifnum\catcode`\|=\@@active \let\outertablebar 
|\else\let\outertablebar  \relax\fi
      \ifnum\catcode`\"=\@@active 
\let\outertablequote"\else\let\outertablequote\relax\fi
    \fi}

Shouldn't it be the other way round? That is first save the current 
meaning of | and ", and then redefine it. So,


\bgroup

\catcode`\|=\@@active
\catcode`\"=\@@active

\gdef\pushouterbarandquote
   {\ifForgetTableBarAndQuote
      \ifnum\catcode`\|=\@@active \let\outertablebar 
|\else\let\outertablebar  \relax\fi
      \ifnum\catcode`\"=\@@active 
\let\outertablequote"\else\let\outertablequote\relax\fi
      \let|\letterbar
      \let"\letterdoublequote
    \fi}

\egroup


This makes sure that || works correctly. The redefinition of " and | 
was added last November.
http://foundry.supelec.fr/plugins/scmsvn/viewcvs.php/tex/context/base/core-tab.tex?root=contextrev&r1=168&r2=173

Aditya
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : https://foundry.supelec.fr/projects/contextrev/
wiki     : http://contextgarden.net
___________________________________________________________________________________

Re: Possible bug in core-tab?

[Aditya Mahajan]

Another bug:

\starttext
\starttablehead
\HL
\stoptablehead
\starttables[|l|l|]
   \VL Some text \VL some text \VL \AR
\stoptables
\stoptext

gives Misplaced \noalign.

Bugfix:

\def\stoptables
   {\chuckTABLEautorow %AM:Added. before the tail, else noalign problem
   \ifconditional\tablerepeattail\else\insertTABLEtail\fi
    \finishTABLE
    \egroup
    \dosplittablebox\tablecontentbox
    \flushnotes
    \egroup}

Aditya
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : https://foundry.supelec.fr/projects/contextrev/
wiki     : http://contextgarden.net
___________________________________________________________________________________

Re: Possible bug in core-tab?

[Hans Hagen]

Aditya Mahajan wrote:
> Another bug:
> 
> \starttext
> \starttablehead
> \HL
> \stoptablehead
> \starttables[|l|l|]
>    \VL Some text \VL some text \VL \AR
> \stoptables
> \stoptext
> 
> gives Misplaced \noalign.
> 
> Bugfix:
> 
> \def\stoptables
>    {\chuckTABLEautorow %AM:Added. before the tail, else noalign problem
>    \ifconditional\tablerepeattail\else\insertTABLEtail\fi
>     \finishTABLE
>     \egroup
>     \dosplittablebox\tablecontentbox
>     \flushnotes
>     \egroup}

ok, patched ... i cross my fingers for side effects -)

-----------------------------------------------------------------
                                           Hans Hagen | PRAGMA ADE
               Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
      tel: 038 477 53 69 | fax: 038 477 53 74 | www.pragma-ade.com
                                              | www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : https://foundry.supelec.fr/projects/contextrev/
wiki     : http://contextgarden.net
___________________________________________________________________________________