From: Hans Hagen <pragma@wxs.nl>
To: mailing list for ConTeXt users <ntg-context@ntg.nl>
Subject: Re: Attributes
Date: Thu, 24 Apr 2014 10:00:16 +0200 [thread overview]
Message-ID: <5358C490.3060207@wxs.nl> (raw)
In-Reply-To: <alpine.LNX.2.00.1404240111250.20881@zbox.seix>
On 4/24/2014 1:39 AM, Stéphane Goujet wrote:
> On Wed, 23 Apr 2014, Hans Hagen wrote:
>> On 4/23/2014 3:07 PM, Stéphane Goujet wrote:
>>> There is still the problem that "node.has_attribute" does not return
>>> "nil" when I expect it should, but that is luatex problem (a check that
>>> a parameter is really an integer should be performed before calling
>>> lua_tointeger), so I will change mailing-list in order to report it.
>> that interface is unlikely to change (e.g. because of performance
>> reasons)
>
> Er... well, the other parameter is already checked, with a
> check_isnode() which is heavier than a lua_isnumber() or lua_isnil(). It
> is possible that the former one is not inlined when the other ones are
> (I did not verify either of these hypotheses).
>
> Anyway, if you do not want to make this change in the code, you
> should change the specification, because now, Luatex reference manual
> says "It returns the value, or, if no match is found, nil", whereas when
> we supply an attribute number which is nil or not a number (therefore it
> cannot ever match), it returns a non-nil value (which, moreover, means
> "true").
> Something like adding "If id is nil or if id is not an integer, the
> result is unspecified", perhaps.
I've added a tracker item and will look at it later (no more changed at
this moment to the code as we're closing in on release i.e. texlive code
freeze).
Hans
-----------------------------------------------------------------
Hans Hagen | PRAGMA ADE
Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
| www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
next prev parent reply other threads:[~2014-04-24 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 13:14 Attributes Stéphane Goujet
2014-04-22 12:05 ` Attributes Hans Hagen
2014-04-22 18:10 ` Attributes Stéphane Goujet
2014-04-23 9:00 ` Attributes Hans Hagen
2014-04-23 13:07 ` Attributes Stéphane Goujet
2014-04-23 17:08 ` Attributes Hans Hagen
2014-04-23 23:39 ` Attributes Stéphane Goujet
2014-04-24 8:00 ` Hans Hagen [this message]
2014-04-24 11:58 ` Attributes Stéphane Goujet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358C490.3060207@wxs.nl \
--to=pragma@wxs.nl \
--cc=ntg-context@ntg.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).