From: Hans Hagen <pragma@wxs.nl>
To: mailing list for ConTeXt users <ntg-context@ntg.nl>
Subject: Re: lpdf.checkedkey has problem with false values
Date: Mon, 15 Sep 2014 21:17:52 +0200 [thread overview]
Message-ID: <54173B60.4050606@wxs.nl> (raw)
In-Reply-To: <CALDha9NUKV=hdToNHDHYWWd=Jg-Vyc7AEtSOXLVGeOtgDMnr+w@mail.gmail.com>
On 9/15/2014 8:25 PM, Michail Vidiassov wrote:
> Dear Hans,
>
>> well, they're just not treated special
>
> IMHO, they have to be treated special.
>
>> you can try this (untested)
>
> I have tested it. It adds nice enhancement, but does not fix the bug
> In the following case
> local a = {}
> a["e"] = "blabla"
> a["t"] = "true"
> a["f"] = "false"
> a["x"] = true
> a["y"] = false
> a["z"] = nil
>
> your new lpdf.checkedkey correctly fetches "t" and "f", where the old
> one failed.
> And your new lpdf.checkedkey fails for "e" - if I attempt to fetch it
> as boolean I get false instead of nil.
> (That is caused by toboolean returning false for unconvertible data -
> unlike tonumber).
>
> But I did not complain about reading strings!
>
> My problem was with "y".
> Both your new and old lpdf.checkedkey fetch it as nil instead of false.
> My (somewhat ugly) idea of the fix is the following
>
> local function lpdf.checkedkey(t,key,variant)
> local pn = t and t[key]
> if pn then
> local tn = type(pn)
> if tn == variant then
> if variant == "string" then
> return pn ~= "" and pn or nil
> elseif variant == "table" then
> return next(pn) and pn or nil
> else
> return pn
> end
> elseif tn == "string" then
> if variant == "number" then
> return tonumber(pn)
> elseif variant == "boolean" then
> if pn == "true" then
> return true
> elseif pn == "false" then
> return false
> end
> end
> end
> elseif t and t[key] ~= nil and variant == "boolean" and
> type(t[key]) == "boolean" then
> return t[key]
> end
> end
more like
function lpdf.checkedkey(t,key,variant)
local pn = t and t[key]
if pn ~= nil then
local tn = type(pn)
if tn == variant then
if variant == "string" then
return pn ~= "" and pn or nil
elseif variant == "table" then
return next(pn) and pn or nil
else
return pn
end
elseif tn == "string" then
if variant == "number" then
return tonumber(pn) -- or nil
elseif variant == "boolean" then
return string.is_boolean(pn,nil,true)
end
end
end
end
-----------------------------------------------------------------
Hans Hagen | PRAGMA ADE
Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
| www.pragma-pod.nl
-----------------------------------------------------------------
___________________________________________________________________________________
If your question is of interest to others as well, please add an entry to the Wiki!
maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage : http://www.pragma-ade.nl / http://tex.aanhet.net
archive : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___________________________________________________________________________________
next prev parent reply other threads:[~2014-09-15 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 14:14 Michail Vidiassov
2014-09-15 14:59 ` Peter Rolf
2014-09-15 15:34 ` Michail Vidiassov
2014-09-15 15:56 ` Aditya Mahajan
2014-09-15 16:12 ` Michail Vidiassov
2014-09-15 17:12 ` Hans Hagen
2014-09-15 18:25 ` Michail Vidiassov
2014-09-15 19:17 ` Hans Hagen [this message]
2014-09-16 3:33 ` Michail Vidiassov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54173B60.4050606@wxs.nl \
--to=pragma@wxs.nl \
--cc=ntg-context@ntg.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).